-
Notifications
You must be signed in to change notification settings - Fork 0
[sc-266853] Text extraction plugin: add partition support #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d3bd117
[sc-266853] Add partition support for input folders
straux 0bf3236
Bump version
straux ebe2229
Fetch the partitions to be retrieved from flow spec
straux 3d0e9cb
Fix integration test requirements
straux 7f6f490
Update dependencies
straux b049b44
Update requirements for Python 3.9 and 3.10
straux 6c1f284
Back to pandas 1.x
straux bf8626c
Update requirement and supported Python versions
straux d7826fb
Bump minor version and update CHANGELOG
straux 562d7da
Fix dependencies security issues
straux 137d27f
Drop Python 3.8, support 3.11
straux f4dde75
Clean requirements
straux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,12 @@ | ||
{ | ||
"acceptedPythonInterpreters": [ | ||
"PYTHON36", | ||
"PYTHON37", | ||
"PYTHON38", | ||
"PYTHON39", | ||
"PYTHON310" | ||
"PYTHON310", | ||
"PYTHON311", | ||
"PYTHON312" | ||
], | ||
"corePackagesSet": "AUTO", | ||
"forceConda": false, | ||
"installCorePackages": true, | ||
"installJupyterSupport": true | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,11 @@ | ||
Pillow==10.3.0 | ||
opencv-python==4.8.1.78 | ||
pytesseract==0.3.13 | ||
pypdfium2==4.17.0 | ||
pytesseract==0.3.7 | ||
Pillow==8.2.0 | ||
matplotlib==3.3.4; python_version <= '3.9' | ||
matplotlib==3.7.1; python_version >= '3.10' | ||
opencv-python==4.5.1.48; python_version <= '3.9' | ||
opencv-python==4.7.0.72; python_version >= '3.10' | ||
deskew==0.10.33 | ||
torch==1.11.0; python_version >= '3.10' | ||
torch==1.9.1; python_version <= '3.9' | ||
easyocr==1.7.0 | ||
packaging==21.3 | ||
matplotlib==3.7.1 | ||
packaging==24.0 | ||
torch==2.8.0 | ||
easyocr==1.7.2 | ||
python-docx==0.8.11 | ||
pypandoc==1.11 | ||
pypandoc==1.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
pandas>=1.0,<1.1 | ||
pytest==6.2.1 | ||
pytest | ||
requests<2.22,>=2 | ||
dataiku-api-client | ||
git+git://github.com/dataiku/dataiku-plugin-tests-utils.git@master#egg=dataiku-plugin-tests-utils | ||
git+https://github.com/dataiku/dataiku-plugin-tests-utils.git@master#egg=dataiku-plugin-tests-utils |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm pretty sure we got the same issue in the native* recipe 😢 : always listing all files. could you quickly double check if you already have your partitioned folder in place please? (i'll take care of opening the card if needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and I found no issue with the embed doc recipe. The KB do not support partitions, so we read all partitions by default, with the ability to customize the selection in the I/O settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was missing the I/O selection settings indeed ! thanks for checking this 🙏