XRD insitu block #1287
XRD insitu block #1287
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 70 70
Lines 4729 4729
=======================================
Hits 3786 3786
Misses 943 943
🚀 New features to boost your workflow:
|
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
c562212 to
91f3404
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/xrd_insitu_block_pre_rebase
|
| Run status |
|
| Run duration | 07m 26s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
336
|
| View all changes introduced in this branch ↗︎ | |
be-smith
requested review from
BenjaminCharmes,
jdbocarsly and
ml-evs
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for XRD insitu data visualization by implementing a new XRDInsituBlock component and registering it as a custom block type. The changes enable users to visualize in-situ X-ray diffraction data alongside temperature or electrochemical data.
- Add
XRDInsituBlockcomponent for XRD insitu data visualization - Register the new component in the custom block types registry
- Enhance UV-Vis insitu block with scan time input functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
webapp/src/resources.js |
Imports and registers the new XRDInsituBlock component in the custom block types |
webapp/src/components/datablocks/XRDInsituBlock.vue |
Implements the complete XRD insitu visualization component with folder selection and data granularity controls |
webapp/src/components/datablocks/UVVisInsituBlock.vue |
Adds scan time input field to the existing UV-Vis insitu block |
| } | ||
| }, | ||
| updateBlock() { | ||
| this.isLoading = true; |
There was a problem hiding this comment.
The property 'isLoading' is being set but is not defined in the component's data properties. This will cause the property to be created on the Vue instance without reactivity, which could lead to unexpected behavior.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Re these suggestions. They are common across NMRInsituBlock, UVVis and XRD. I assume this.isLoading should be defined in data instead of this.isUpdating and set to false.
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
5e04cde to
c7aff64
Compare
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
fea1280 to
2e86260
Compare
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
2e86260 to
913fa95
Compare
…ur of scan time box for when it triggers a recalculation of the data
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ies_source, which has default log
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
1a664ff to
da1b336
Compare
3 participants
Add XRD insitu block for PR datalab-org/datalab-app-plugin-insitu#67
The new block should look as below with the option to toggle between modes