Skip to content

Remove name reset in CreateItemModal #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove name reset in CreateItemModal #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a2930
Remove name reset in CreateItemModal
BenjaminCharmes Oct 3, 2025
117ae65
Clear name between two equipment in cypress
BenjaminCharmes Oct 3, 2025
b592ac5
Clear name between two equipment in cypress
BenjaminCharmes Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions webapp/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Cypress.Commands.add(
cy.get('[data-testid="create-item-form"]').within(() => {
cy.findByText("Add new item").should("exist");
cy.findByLabelText("ID:").type(item_id);
cy.findByLabelText("Name:").clear();
if (name) {
cy.findByLabelText("Name:").type(name);
}
Expand Down Expand Up @@ -153,6 +154,7 @@ Cypress.Commands.add("createEquipment", (item_id, name = null, date = null) => {

cy.get('[data-testid="create-equipment-form"]').within(() => {
cy.findByText("Add equipment").should("exist");
cy.findByLabelText("Name:").clear();
cy.findByLabelText("ID:").type(item_id);
if (name) {
cy.findByLabelText("Name:").type(name);
Expand Down
1 change: 0 additions & 1 deletion webapp/src/components/CreateEquipmentModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ export default {
document.getElementById(this.item_id).scrollIntoView({ behavior: "smooth" });
}
this.item_id = null;
this.name = null;
this.date = this.now(); // reset date to the new current time
})
.catch((error) => {
Expand Down
1 change: 0 additions & 1 deletion webapp/src/components/CreateItemModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ export default {
// new items always show up at the top of the sample table
// // document.getElementById(this.item_id).scrollIntoView({ behavior: "smooth" });
this.item_id = null;
this.name = null;
this.date = this.now(); // reset date to the new current time
})
.catch((error) => {
Expand Down