Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace word 'crop' with 'resize' #1245

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

JoKeyser
Copy link
Contributor

Hi, I think the word "crop" in this sentence may be slightly misleading and should be replaced with "resize".
To me the image operations of cropping and resizing are very different.
Since the text and examples beyond that sentence all talk about resizing, it should also be called resizing here as well.

@malikwirin
Copy link
Contributor

Doesn't cropping just mean to resize it for it to become smaller? If so it would be a good word to avoid repetition

@JoKeyser
Copy link
Contributor Author

Doesn't cropping just mean to resize it for it to become smaller? If so it would be a good word to avoid repetition

Hi, thanks for checking in.
I think the word cropping refers to "the removal of unwanted outer areas from an image", like written in wikipedia. That will also reduce the size of the image, and thus is related, but it's an entirely different operation.
I think it's both confusing to users who know the difference and those who don't; it may only not be confusing to those who think the two concepts are the same :).

@adswa
Copy link
Contributor

adswa commented Dec 31, 2024

Thanks both for the PR and short discussion here! I am not particularly attached to the word, I would be fine changing it.

@all-contributors please add @malikwirin for review

@all-contributors please add @JoKeyser for bug

@JoKeyser feel free to add yourself to the .zenodo.json file of this repository, in the second to last position (before Michael Hanke), or leave your name, orcid and affiliation in a comment and I'll add you. :)

Copy link
Contributor

@adswa

I've put up a pull request to add @malikwirin! 🎉

@adswa adswa merged commit c7dc3b6 into datalad-handbook:main Dec 31, 2024
3 checks passed
Copy link

welcome bot commented Dec 31, 2024

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@JoKeyser JoKeyser deleted the replace-crop-with-resize branch January 2, 2025 09:47
@JoKeyser
Copy link
Contributor Author

JoKeyser commented Jan 2, 2025

@adswa , thank you very much, I've opened a PR #1250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants