Skip to content

Conversation

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Sep 28, 2025

sits on top of

TODOs

  • address 3 failing tests
FAILED ../tests/test_containers.py::test_container_update - AssertionError
FAILED ../tests/test_run.py::test_extra_inputs - AttributeError: 'NoneType' object has no attribute 'get'
FAILED ../tests/test_schemes.py::test_docker - datalad.runner.exception.CommandError: CommandError: 'singularity build image docker://busybox@sha256:7964ad52e396a6e045c39b5a44438424ac52e12e4d5a25d94895f2058cb863a0' failed with exitcode 255 under /crippledfs/datalad_temp_test_docker2kzv5u76/.datalad/environments/bb

edit: might not show that CI run below but it is available under https://github.com/datalad/datalad-container/actions/workflows/test_crippledfs.yml

otherwise even singularity does not install
…emplate

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -e \"s,helloworld,container,g\" < ../datalad-extension-template/.github/workflows/test_crippledfs.yml > .github/workflows/test_crippledfs.yml",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic added tests Add or improve existing tests CHANGELOG-missing labels Sep 28, 2025
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (89aab60) to head (de1fc54).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   94.60%   93.88%   -0.72%     
==========================================
  Files          24       24              
  Lines        1112     1112              
==========================================
- Hits         1052     1044       -8     
- Misses         60       68       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic marked this pull request as ready for review December 3, 2025 03:29
@yarikoptic
Copy link
Member Author

hm, pushed

(deno) yoh@typhon:/mnt/DATA/data/yoh/1076_spacetop$ git lg | head -n 40
*   9259ea12cc - (HEAD -> master, openneuro-git/main) Merge remote-tracking branch 'typhon/master' (8 hours ago) [Yaroslav Halchenko]
|\  
| * 5b5865b062 - [DATALAD RUNCMD] Run bids-validators (2 weeks ago) [Yaroslav Halchenko]
| * c71c8d92b4 - Empty commit to facilitate revalidation (2 weeks ago) [Yaroslav Halchenko]
| *   32eb4b8a26 - Merge branch 'main' of https://openneuro.org/git/0/ds005256 (3 months ago) [Yaroslav Halchenko]
| |\  
| | * 432decbbbd - [OpenNeuro] Recorded changes (3 months ago) [Heejung Jung]
| | * 6ef505a774 - [OpenNeuro] Recorded changes (3 months ago) [Git Worker]
| * | 3cbb5f2c9a - [DATALAD RUNCMD] Run bids-validators (3 months ago) [Yaroslav Halchenko]
| * | b4470c7714 - BIDS and git ignore more files (3 months ago) [Yaroslav Halchenko]
| |/  
* |   57cca1e5e0 - Merge remote-tracking branch 'gh-psadil/fix/fmap-linking' (9 hours ago) [Yaroslav Halchenko]
|\ \  
| |/  
|/|   
| * fca7c3036a - [DATALAD RUNCMD] populate select sub/ses IntendedFor with relaxed rules (8 days ago) [Patrick Sadil]
| * e8a7930df9 - prepare for selectively populating IntendedFor with relaxed rules (8 days ago) [Patrick Sadil]
...

so on openneuro-git

(deno) yoh@typhon:/mnt/DATA/data/yoh/1076_spacetop$ git remote get-url openneuro-git
https://openneuro.org/git/0/ds005256

but not here, may be synced only periodically , @effigies ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant