Enh/sdk updates #163

goanpeca · 2025-09-29T05:06:06Z

No description provided.

netlify · 2025-09-29T05:06:11Z

✅ Deploy Preview for datalayer-core ready!

Name	Link
🔨 Latest commit	`3948d6e`
🔍 Latest deploy log	https://app.netlify.com/projects/datalayer-core/deploys/68dd1a55f6b02400083999ad
😎 Deploy Preview	https://deploy-preview-163--datalayer-core.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull Request Overview

This PR refactors the SDK architecture by moving the main SDK from src/sdk/ to src/client/ and updates all imports to reflect this change. The primary purpose is to rename DatalayerSDK to DatalayerClient and restructure the codebase for better organization.

Key Changes:

Renamed DatalayerSDK to DatalayerClient across the entire codebase
Moved SDK directory from src/sdk/ to src/client/
Updated all import paths to reflect the new structure
Simplified documentation comments and removed extensive details from code comments

Reviewed Changes

Copilot reviewed 116 out of 124 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`tsconfig.app.json`	Added test file exclusions to TypeScript build configuration
`src/stateful/runtimes/apis.ts`	Updated import path from three levels up to two levels up
`src/stateful/runtimes/actions.ts`	Updated multiple import paths to reflect new directory structure
`src/stateful/jupyter/exec/Snippets.ts`	Removed detailed documentation comments from interface methods
`src/stateful/index.ts`	Updated export path for DatalayerApi
Multiple component files	Updated import paths from `sdk/stateful` to `stateful`
`src/client/` directory	New location containing renamed and restructured SDK code
`src/index.ts`	Updated exports to use `DatalayerClient` instead of `DatalayerSDK`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-01T12:21:47Z

src/stateful/runtimes/apis.ts

  IRuntimeType,
  IRuntimeLocation,
-} from '../../../models';
+} from '../../models';


Import path suggests this file is now two directories deep instead of three. Consider verifying that all model imports are still accessible and that the directory structure is consistent with the intended architecture.

Suggested change

} from '../../models';

} from '../models';

Copilot · 2025-10-01T12:21:48Z

src/client/models/Runtime.ts

+      burningRate: this.burningRate,
+
+      // URLs and tokens
+      // FIXME: Consider renaming? jupyterServerUrl and jupyterServerToken


FIXME comment indicates uncertainty about field naming. Consider either renaming these fields to be more descriptive (jupyterServerUrl/jupyterServerToken) or removing the comment if the current naming is acceptable.

Suggested change

// FIXME: Consider renaming? jupyterServerUrl and jupyterServerToken

Copilot · 2025-10-01T12:21:48Z

src/client/models/Notebook.ts

+    // FIXME: check if both are needed, and use the existing values if only one provided
+    this._checkDeleted();
+    const token = (this as any)._sdk.getToken();
+    const spacerRunUrl = (this as any)._sdk.getSpacerRunUrl();
+    const updateData: UpdateNotebookRequest = {};
+    if (name !== undefined) updateData.name = name;
+    if (description !== undefined) updateData.description = description;
+
+    await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);
+    // FIXME: handle partial updates


FIXME comment suggests incomplete implementation. The update method should handle partial updates properly by using existing values when only one parameter is provided.

Suggested change

// FIXME: check if both are needed, and use the existing values if only one provided

this._checkDeleted();

const token = (this as any)._sdk.getToken();

const spacerRunUrl = (this as any)._sdk.getSpacerRunUrl();

const updateData: UpdateNotebookRequest = {};

if (name !== undefined) updateData.name = name;

if (description !== undefined) updateData.description = description;

await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);

// FIXME: handle partial updates

// Use existing values for missing parameters to ensure both fields are sent

this._checkDeleted();

const token = (this as any)._sdk.getToken();

const spacerRunUrl = (this as any)._sdk.getSpacerRunUrl();

const updateData: UpdateNotebookRequest = {};

updateData.name = name !== undefined ? name : this.name;

updateData.description = description !== undefined ? description : (this._data.description || '');

await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);

Copilot · 2025-10-01T12:21:49Z

src/client/models/Notebook.ts

+    await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);
+    // FIXME: handle partial updates


FIXME comment indicates incomplete implementation. The method should update internal data with the response from the API call to maintain consistency.

Suggested change

await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);

// FIXME: handle partial updates

const updatedNotebook = await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);

if (updatedNotebook) {

this._data = updatedNotebook;

}

Copilot · 2025-10-01T12:21:49Z

src/client/models/Lexical.ts

+    // FIXME: check if both are needed, and use the existing values if only one provided
+    this._checkDeleted();
+    const token = this._getToken();
+    const spacerRunUrl = this._getSpacerRunUrl();
+    const updateData: UpdateLexicalRequest = {};
+    if (name !== undefined) updateData.name = name;
+    if (description !== undefined) updateData.description = description;


FIXME comment suggests incomplete implementation. Similar to the Notebook model, this update method should handle partial updates by using existing values when parameters are undefined.

Suggested change

// FIXME: check if both are needed, and use the existing values if only one provided

this._checkDeleted();

const token = this._getToken();

const spacerRunUrl = this._getSpacerRunUrl();

const updateData: UpdateLexicalRequest = {};

if (name !== undefined) updateData.name = name;

if (description !== undefined) updateData.description = description;

// Use existing values for name/description if parameters are undefined

this._checkDeleted();

const token = this._getToken();

const spacerRunUrl = this._getSpacerRunUrl();

const updateData: UpdateLexicalRequest = {

name: name !== undefined ? name : this.name,

description: description !== undefined ? description : this.description,

};

Copilot · 2025-10-01T12:21:49Z

src/client/models/Credits.ts

+   * Convert to JSON representation.
+   */
+  toJSON(): CreditsInfo & { reservations: CreditReservation[] } {
+    // FIXME


FIXME comment without explanation is unclear. Either provide a specific description of what needs to be fixed or remove the comment if the implementation is correct.

Suggested change

// FIXME

echarles

LGTM Thx @goanpeca

goanpeca added 7 commits September 24, 2025 20:08

Remove desktop workflow files (moved to desktop repository)

461ade3

Platform abstraction layer implementation with

1838e07

Update oauth on api

708f7b2

Create shared domain models

fac05cf

Update SDK to include handlers and better cross platform functionality

029bfc6

Update storage model and handlers for sdk and add more models to api

54a88e7

Update models and sdk methods

c5af6bb

goanpeca added 3 commits September 29, 2025 03:55

Flatten out sdk

4e03d2d

Remove state and storeage and simplify sdk

eb2318a

Update basic testing

89618dc

goanpeca self-assigned this Oct 1, 2025

Fix tests

3948d6e

goanpeca marked this pull request as ready for review October 1, 2025 12:20

goanpeca requested review from Copilot and echarles October 1, 2025 12:20

Copilot AI reviewed Oct 1, 2025

View reviewed changes

echarles approved these changes Oct 1, 2025

View reviewed changes

echarles merged commit 16db812 into datalayer:main Oct 1, 2025
13 checks passed

goanpeca deleted the enh/sdk-updates branch October 1, 2025 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Enh/sdk updates #163

Enh/sdk updates #163

Uh oh!

goanpeca commented Sep 29, 2025

Uh oh!

netlify bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

echarles left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);
		// FIXME: handle partial updates

-    await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);
-    // FIXME: handle partial updates
+    const updatedNotebook = await notebooks.updateNotebook(token, this.uid, updateData, spacerRunUrl);
+    if (updatedNotebook) {
+      this._data = updatedNotebook;
+    }

Uh oh!

Enh/sdk updates #163

Enh/sdk updates #163

Uh oh!

Conversation

goanpeca commented Sep 29, 2025

Uh oh!

netlify bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for datalayer-core ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

echarles left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Sep 29, 2025 •

edited

Loading