[AGENT-6081] Fix class label files not working for binary models #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elatt
reviewed
Aug 14, 2024
.github/workflows/docker-image.yml
Outdated
| @@ -3,6 +3,8 @@ name: Docker Image CI | |||
| on: | |||
| push: | |||
| branches: [ "main" ] | |||
| paths: | |||
| - environments/java_codegen_monitoring/Makefile | |||
There was a problem hiding this comment.
Can you pull the version number out into a file with just the version in it. It's easy then to read it in from the Makefile. This way changes to the Makefile itself won't trigger a re-publish accidentally.
| @@ -2,7 +2,7 @@ SHELL = /bin/sh | |||
|
|
|||
| NS := datarobot-oss | |||
| IMAGE_NAME := mlops-sap-monitoring-scoring-code | |||
| VERSION := 1.0.0 | |||
| VERSION := 1.0.1 | |||
There was a problem hiding this comment.
If this was split into a dedicated file, I'm pretty sure you can use a shell call with cat to slurp in the version.
elatt
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update start_server.sh to only include Class label files for multiclass deployments.
This was causing to fail for binary classification since it does not require this file.
*Update tests cases to cover this, and actually run the docker image with different target type
1.0so no changes neede there.