DOC-5558 attribute usage and classic rename #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
eric-schneider
approved these changes
Dec 4, 2025
|
Build successful! ✅
Deploying draft. |
eric-schneider
approved these changes
Dec 4, 2025
Contributor
eric-schneider
left a comment
eric-schneider
left a comment
There was a problem hiding this comment.
LGTM! I'm going to be refactoring the in-progress content, so I only spot checked changes to those files. I'm glad you made the changes though, since the attribute usage will be in a good place to be refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_to the same ones with-astra-dbwithproduct-short