Skip to content

Comments

Ignore C# build stuff#19

Merged
toptobes merged 3 commits intomasterfrom
ske-ignore-cs-build-stuff
Feb 20, 2026
Merged

Ignore C# build stuff#19
toptobes merged 3 commits intomasterfrom
ske-ignore-cs-build-stuff

Conversation

@skedwards88
Copy link
Collaborator

@skedwards88 skedwards88 commented Feb 20, 2026 •
edited
Loading

Proposed fix from bob to avoid the following error. Also giignore the generated sln file

[OUTPUT] Building test plan...
[OUTPUT] -> Found 348 test roots
[OUTPUT] -> Found 4 files to test
[OUTPUT] 
[DEBUG] Installing JSFixture dependencies in /Users/sarah.edwards/repos/astra-client-docs-tests/.
[EXCEPTION] Error running snapshot tests for language 'CSHARP' in test root 'collections-update-setOnInsert'
[FAILED] --------------------------------
[FAILED] collections-update-setOnInsert (CSHARP) => Errored
[FAILED] com.dtsx.docs.core.runner.RunException: Main method not found in C# script
[FAILED] 	at com.dtsx.docs.core.runner.drivers.impls.CSharpDriver.preprocessScript(CSharpDriver.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.setupFileForTesting(ExecutionEnvironment.java:144)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.withTestFileCopied(ExecutionEnvironment.java:100)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.lambda$run$3(SnapshotTestStrategy.java:96)
[FAILED] 	at com.dtsx.docs.core.runner.tests.snapshots.verifier.SnapshotVerifier.verify(SnapshotVerifier.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.run(SnapshotTestStrategy.java:89)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeLanguage(SequentialExecutionStrategy.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.lambda$executeImpl$0(SequentialExecutionStrategy.java:46)
[FAILED] 	at java.base/java.util.Map.forEach(Map.java:733)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeImpl(SequentialExecutionStrategy.java:45)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.ExecutionStrategy.execute(ExecutionStrategy.java:17)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.executeLanguageWithIsolation(IsolatedExecutionStrategy.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.lambda$executeImpl$0(IsolatedExecutionStrategy.java:37)
[FAILED] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
[FAILED] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
[FAILED] 	at java.base/java.lang.VirtualThread.run(VirtualThread.java:329)
[FAILED] 
[FAILED] --------------------------------
[FAILED] --------------------------------
[FAILED] collections-update-setOnInsert (CSHARP) => Errored
[FAILED] com.dtsx.docs.core.runner.RunException: Main method not found in C# script
[FAILED] 	at com.dtsx.docs.core.runner.drivers.impls.CSharpDriver.preprocessScript(CSharpDriver.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.setupFileForTesting(ExecutionEnvironment.java:144)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.withTestFileCopied(ExecutionEnvironment.java:100)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.lambda$run$3(SnapshotTestStrategy.java:96)
[FAILED] 	at com.dtsx.docs.core.runner.tests.snapshots.verifier.SnapshotVerifier.verify(SnapshotVerifier.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.run(SnapshotTestStrategy.java:89)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeLanguage(SequentialExecutionStrategy.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.lambda$executeImpl$0(SequentialExecutionStrategy.java:46)
[FAILED] 	at java.base/java.util.Map.forEach(Map.java:733)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeImpl(SequentialExecutionStrategy.java:45)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.ExecutionStrategy.execute(ExecutionStrategy.java:17)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.executeLanguageWithIsolation(IsolatedExecutionStrategy.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.lambda$executeImpl$0(IsolatedExecutionStrategy.java:37)
[FAILED] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
[FAILED] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
[FAILED] 	at java.base/java.lang.VirtualThread.run(VirtualThread.java:329)
[FAILED] 
[FAILED] --------------------------------
[FAILED] --------------------------------
[FAILED] collections-update-setOnInsert (CSHARP) => Errored
[FAILED] com.dtsx.docs.core.runner.RunException: Main method not found in C# script
[FAILED] 	at com.dtsx.docs.core.runner.drivers.impls.CSharpDriver.preprocessScript(CSharpDriver.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.setupFileForTesting(ExecutionEnvironment.java:144)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.withTestFileCopied(ExecutionEnvironment.java:100)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.lambda$run$3(SnapshotTestStrategy.java:96)
[FAILED] 	at com.dtsx.docs.core.runner.tests.snapshots.verifier.SnapshotVerifier.verify(SnapshotVerifier.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.run(SnapshotTestStrategy.java:89)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeLanguage(SequentialExecutionStrategy.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.lambda$executeImpl$0(SequentialExecutionStrategy.java:46)
[FAILED] 	at java.base/java.util.Map.forEach(Map.java:733)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeImpl(SequentialExecutionStrategy.java:45)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.ExecutionStrategy.execute(ExecutionStrategy.java:17)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.executeLanguageWithIsolation(IsolatedExecutionStrategy.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.lambda$executeImpl$0(IsolatedExecutionStrategy.java:37)
[FAILED] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
[FAILED] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
[FAILED] 	at java.base/java.lang.VirtualThread.run(VirtualThread.java:329)
[FAILED] 
[FAILED] --------------------------------
[FAILED] --------------------------------
[FAILED] collections-update-setOnInsert (CSHARP) => Errored
[FAILED] com.dtsx.docs.core.runner.RunException: Main method not found in C# script
[FAILED] 	at com.dtsx.docs.core.runner.drivers.impls.CSharpDriver.preprocessScript(CSharpDriver.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.setupFileForTesting(ExecutionEnvironment.java:144)
[FAILED] 	at com.dtsx.docs.core.runner.ExecutionEnvironment.withTestFileCopied(ExecutionEnvironment.java:100)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.lambda$run$3(SnapshotTestStrategy.java:96)
[FAILED] 	at com.dtsx.docs.core.runner.tests.snapshots.verifier.SnapshotVerifier.verify(SnapshotVerifier.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.test.SnapshotTestStrategy$Runner.run(SnapshotTestStrategy.java:89)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeLanguage(SequentialExecutionStrategy.java:61)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.lambda$executeImpl$0(SequentialExecutionStrategy.java:46)
[FAILED] 	at java.base/java.util.Map.forEach(Map.java:733)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.SequentialExecutionStrategy.executeImpl(SequentialExecutionStrategy.java:45)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.ExecutionStrategy.execute(ExecutionStrategy.java:17)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.executeLanguageWithIsolation(IsolatedExecutionStrategy.java:56)
[FAILED] 	at com.dtsx.docs.core.runner.tests.strategies.execution.IsolatedExecutionStrategy.lambda$executeImpl$0(IsolatedExecutionStrategy.java:37)
[FAILED] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
[FAILED] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
[FAILED] 	at java.base/java.lang.VirtualThread.run(VirtualThread.java:329)
[FAILED] 
[FAILED] --------------------------------
[OUTPUT] Test Summary:
[OUTPUT] - Total tests: 4
[OUTPUT] - Passed tests: 0
[OUTPUT] - Failed tests: 4

@toptobes toptobes requested a review from Copilot February 20, 2026 22:40
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for reading and respecting .gitignore patterns in the examples folder during test plan building. The primary motivation is to prevent C# build artifacts (like bin/ and obj/ directories) from being incorrectly processed as test files, which was causing test failures. The PR also adds the C# solution file astra-client-docs-tests.sln to the root .gitignore.

Changes:

  • Added .gitignore pattern parsing and filtering to skip files matching gitignore patterns in the examples directory
  • Added astra-client-docs-tests.sln to the root .gitignore file
  • Implemented gitignore-style glob pattern to regex conversion

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 10 comments.

File Description
.gitignore Added C# solution file to be ignored at the repository root
src/main/java/com/dtsx/docs/core/planner/TestPlanBuilder.java Implemented .gitignore file reading, pattern parsing, and file filtering logic with new helper methods and updated existing methods to use gitignore filtering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@toptobes toptobes merged commit 72117d7 into master Feb 20, 2026
1 of 2 checks passed
@toptobes toptobes deleted the ske-ignore-cs-build-stuff branch February 20, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skedwards88 @toptobes