Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias upsert => upsert_one (with deprecation) #179

Closed
hemidactylus opened this issue Jan 30, 2024 · 2 comments · Fixed by #180
Closed

alias upsert => upsert_one (with deprecation) #179

hemidactylus opened this issue Jan 30, 2024 · 2 comments · Fixed by #180
Assignees
@erichare

Comments

@hemidactylus
Copy link
Collaborator

out of least-surprise, cf. insert_one and insert_many for instance.
@cbornet
Copy link
Collaborator

cbornet commented Jan 30, 2024

shouldn't it be aliased to upsert_one ?

@hemidactylus hemidactylus changed the title alias upsert => upsert_many (with deprecation) alias upsert => upsert_one (with deprecation) Jan 30, 2024
@hemidactylus
Copy link
Collaborator Author

Oups! @cbornet I must increase my daily coffee again, it looks. Thanks!

@erichare erichare self-assigned this Jan 31, 2024
erichare added a commit that referenced this issue Jan 31, 2024
@erichare
Fix #179 : alias for upsert calls
0d18faa
@erichare erichare linked a pull request Jan 31, 2024 that will close this issue
Fix #179 : alias for upsert calls #180
Merged
erichare added a commit that referenced this issue Jan 31, 2024
@erichare
Fix #179 : alias for upsert calls (#180)
bb33ec3 
* Fix #179 : alias for upsert calls

* Switch to new deprecation module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erichare erichare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #179 : alias for upsert calls datastax/astrapy
3 participants
@erichare @cbornet @hemidactylus