Fix #179 : alias for upsert calls #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
reviewed
Jan 31, 2024
cbornet
reviewed
Jan 31, 2024
astrapy/db.py
Outdated
| # Deprecated: call the upsert_one method | ||
| DEPRECATION_MESSAGE = "Method 'upsert' of AstraDBCollection is deprecated. Please switch to method 'upsert_one'." | ||
|
|
||
| warn(DEPRECATION_MESSAGE, DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
We could factorize in a deprecation_warning method ?
There was a problem hiding this comment.
Agree- maybe a method decorator is even less intrusive. For that matter we might just use this.
There was a problem hiding this comment.
I like this idea! I'm going to push an update now which uses the deprecation module. it looks very dev friendly, and seems to work with our tests. We can easily update the messages etc and now they're just decorators on the function itself. See the update and let me know if you guys have any further feedback @cbornet @hemidactylus . Thanks :)
hemidactylus
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate upsert(), use upsert_one() instead