Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a test collecting all non-equality operators in the filters to find #162

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

hemidactylus
Copy link
Collaborator

I am not even sure such a test belongs to astrapy, in a sense (astrapy's role as a passthrough for the payload is somewhat trivial here) - on the other hand it could help early discovery of regressions elsewhere. WDYT?

(this comes from an equivalent Java test, where the role of the sdk is more substantial since it's a fluent-interface "builder" kind of thing. I'm open to trash this or merge, whatever the consensus is).

Copy link
Collaborator

@erichare erichare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome!

@erichare erichare merged commit 890ce5a into master Jan 10, 2024
2 checks passed
@erichare erichare deleted the SL-api-operator-testing branch January 10, 2024 16:22
@cbornet
Copy link
Collaborator

cbornet commented Jan 12, 2024

If this is a test of the API more than astrapy itself, maybe this could go to another test file/suite ?
We want to align sync/async and it doesn't really make sense to duplicate this test in async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants