Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #181 - use request handler for db ops #185

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix #181 - use request handler for db ops #185

merged 1 commit into from
Jan 31, 2024

Conversation

erichare
Copy link
Collaborator

Ensure we properly handle 400 and 500 HTTP errors by using the HTTP request handling classes previously developed, for AstraDB class

@erichare erichare linked an issue Jan 31, 2024 that may be closed by this pull request
AstraDB (+async) should use the request handler for correct management of 4xx and 5xx #181
Closed
nicoloboschi
nicoloboschi approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichare erichare merged commit 6819e67 into master Jan 31, 2024
2 checks passed
@erichare erichare deleted the bugfix/#181-request-handler branch January 31, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@cbornet cbornet Awaiting requested review from cbornet

@hemidactylus hemidactylus Awaiting requested review from hemidactylus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AstraDB (+async) should use the request handler for correct management of 4xx and 5xx
2 participants
@erichare @nicoloboschi