Complete removal of "core" from the idiomatic API #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adbdatabaseadmin eq method
… version bump for 1.5
hemidactylus
changed the title
…atastax/astrapy into SL-database-uses-api-commander
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last big item of technical debt from astrapy. The whole client API is rewritten not to use any of the "core" (or pre-1.0) library, relying instead of the
APICommanderfor all of its interactions with both the Data and DevOps APIs.Additionally, with version 1.5 in mind, a deprecation notice is put in place for the whole "core" submodule (slated for removal in v2).
The rewriting of the whole client logic to do without "core" has implications in several places (see the CHANGES file for a quick map); but, notably, it allows to entirely remove the catch-and-reraise mechanism that used to be in place for most request-issuing methods in order to recast exceptions from core into "idiomatic" exceptions. This, incidentally, allows for a better control of the return types from said methods.