Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15578

Port into main-5.0 commit 7e7230c

CNDB-15381: Port CASSANDRA-20888 index hints improvements (https://github.com/datastax/cassandra/pull/2004)
Port some of the improvements for index hints done by
[CASSANDRA-20888](https://issues.apache.org/jira/browse/CASSANDRA-20888),
especially the ones in messaging. Also clean up unused methods in index hints.

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks
Copy link

Looks like there are test regressions.

@michaelsembwever
Copy link
Member Author

@djatnieks , tests are good now. cannot reproduce ForceRepairTest.

…#2004)

Port some of the improvements for index hints done by
[CASSANDRA-20888](https://issues.apache.org/jira/browse/CASSANDRA-20888),
especially the ones in messaging. Also clean up unused methods in index hints.
@michaelsembwever michaelsembwever force-pushed the mck-cndb-15578-0-main-5.0 branch from 944ce04 to f8be6ca Compare October 22, 2025 11:04
@michaelsembwever michaelsembwever merged commit 6f77404 into main-5.0 Oct 22, 2025
468 of 517 checks passed
@michaelsembwever michaelsembwever deleted the mck-cndb-15578-0-main-5.0 branch October 22, 2025 11:45
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2065 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-_jdk11 REGRESSION 🔴🔵 0 / 13
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 13
o.a.c.distributed.test.repair.ForceRepairTest.forceWithDifference () NEW 🔴🔴 7 / 13
o.a.c.utils.binlog.BinLogTest.testTruncationReleasesLogSpace (compression) REGRESSION 🔵🔴 0 / 13

Found 5 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants