Avoid lambda allocation in AtomicInteger max update in MutablePQVectors#639
Open
michaeljmarshall wants to merge 1 commit intodatastax:mainfrom
Open
Avoid lambda allocation in AtomicInteger max update in MutablePQVectors#639michaeljmarshall wants to merge 1 commit intodatastax:mainfrom
michaeljmarshall wants to merge 1 commit intodatastax:mainfrom
Conversation
MarkWolters
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor optimization to reduce object allocations on the hot path when we're adding vectors to
MutablePQVectors. The object allocation happens when we have a capturing lambda, which is different on every call to this method. Instead, we can use theaccumulateAndGetmethod, which takes the value we want to offer and then takes a non-capturing lambdaMath::max, which means we won't allocate an object per call.