Skip to content

Commit

Permalink
Release 8.0.3 (#70)
Browse files Browse the repository at this point in the history
## What's changed

* fix: add sassOptions.outputStyle to expanded in rspack.config.js
(#65)
* deps: remove @storybook/addon-mdx-gfm as it breaks the build
(#68)
* feat: allow setting devtool=false
(#69)
  • Loading branch information
puehringer authored Apr 24, 2024
2 parents afb89c4 + 7528e64 commit 8c1563e
Show file tree
Hide file tree
Showing 3 changed files with 2,204 additions and 2,846 deletions.
9 changes: 8 additions & 1 deletion config/rspack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ module.exports = (webpackEnv, argv) => {
}

const isDevServerOnly = env.dev_server_only?.toLowerCase() === 'true';
const devtool = (env.devtool?.toLowerCase() === 'false' ? false : env.devtool) || (isEnvDevelopment ? 'eval-cheap-module-source-map' : 'source-map');
const isReactRefresh = isDevServer && isEnvDevelopment;

const now = new Date();
Expand Down Expand Up @@ -92,7 +93,7 @@ module.exports = (webpackEnv, argv) => {
mode,
// Logging noise constrained to errors and warnings
stats: 'errors-warnings', // { logging: 'verbose', timings: true, assets: true },
devtool: isEnvDevelopment ? 'cheap-module-source-map' : 'source-map',
devtool,
// These are the "entry points" to our application.
// This means they will be the "root" imports that are included in JS bundle.
entry: Object.fromEntries(
Expand All @@ -105,6 +106,9 @@ module.exports = (webpackEnv, argv) => {
? {
static: path.resolve(workspacePath, 'bundles'),
compress: true,
// Explicitly set hot to true and liveReload to false to ensure that hot is preferred over liveReload
hot: true,
liveReload: false,
// Explicitly set the host to ipv4 local address to ensure that the dev server is reachable from the host machine: https://github.com/cypress-io/cypress/issues/25397
host: '127.0.0.1',
open: true,
Expand Down Expand Up @@ -333,6 +337,9 @@ module.exports = (webpackEnv, argv) => {
loader: 'sass-loader',
options: {
sourceMap: true, // <-- !!IMPORTANT!!
sassOptions: {
outputStyle: 'expanded', // @see https://github.com/FortAwesome/Font-Awesome/issues/17644#issuecomment-1703318326
},
},
},
],
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "visyn_scripts",
"description": "",
"version": "8.0.2",
"version": "8.0.3",
"author": {
"name": "datavisyn GmbH",
"email": "contact@datavisyn.io",
Expand Down Expand Up @@ -42,7 +42,6 @@
"@storybook/addon-essentials": "^7.6.17",
"@storybook/addon-interactions": "^7.6.17",
"@storybook/addon-links": "^7.6.17",
"@storybook/addon-mdx-gfm": "^7.6.17",
"@storybook/addon-styling": "^1.3.7",
"@storybook/addon-styling-webpack": "^0.0.6",
"@storybook/cli": "^7.6.17",
Expand Down
Loading

0 comments on commit 8c1563e

Please sign in to comment.