Skip to content

feat: add ability to build ts|tsx from node_modules #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Nov 2, 2023

Migration guide for Node 20 and no_dist:

First, create a no_dist branch and do the following in the package.json:

  • Replace all of our dependencies with the #no_dist branch
  • Update the exports/main/types fields. This has to be done according what is already exported, but if no exports field exists, you the following:
  "main": "src/index.ts",
  "types": "src/index.ts",
  "exports": {
    ".": {
      "types": [
        "./dist/index.d.ts",
        "./src/index.ts"
      ],
      "import": [
        "./dist/index.js",
        "./src/index.ts"
      ],
      "default": [
        "./dist/index.js",
        "./src/index.ts"
      ]
    },
    "./phovea_registry": [
      "./dist/phovea_registry.js",
      "./src/phovea_registry.ts"
    ],
    "./dist/phovea_registry": [
      "./dist/phovea_registry.js",
      "./src/phovea_registry.ts"
    ],
    "./dist/scss/*": [
      "./dist/scss/*",
      "./src/scss/*"
    ],
    "./package.json": "./package.json"
  },
  • Switch to Node 20 using nvm use 20.9 (this should be the default! Uninstall all other node versions using nvm uninstall ...)
  • Then install and test using rm -rf yarn.lock node_modules && yarn && yarn run all && yarn webpack:prod && yarn start dev_server_only=true
  • In the end, make sure to create a PR and link it in the repo sheet (see Node20 and no_dist column)

If you encounter any issues, please report them.

@puehringer puehringer requested a review from a team as a code owner November 2, 2023 21:59
@puehringer puehringer changed the title Prepare no_dist version feat: add ability to build ts|tsx from node_modules Nov 2, 2023
@puehringer puehringer added release: patch PR merge results in a new patch version type: feature New feature or request labels Nov 2, 2023
@puehringer puehringer force-pushed the no_dist branch 2 times, most recently from 49ad1dc to b348b85 Compare November 3, 2023 15:40
@puehringer puehringer merged commit 9df508c into develop Nov 9, 2023
@puehringer puehringer deleted the no_dist branch November 9, 2023 19:00
@thinkh thinkh mentioned this pull request Nov 21, 2023
thinkh added a commit that referenced this pull request Nov 21, 2023
## What's Changed
* feat: ignore playwright folder in jest config by @puehringer in
#45
* deps: pin @swc/core to 1.3.95 by @dvmartinweigl in
#47
* feat: add ability to build ts|tsx from node_modules by @puehringer in
#46

## New Contributors
* @dvmartinweigl made their first contribution in
#47

**Full Changelog**:
v5.1.0...v6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant