Skip to content

deps: pin @swc/core to 1.3.95 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

dvmartinweigl
Copy link
Contributor

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • pin @swc/core version to 1.3.95 as there was an webpack error appearing in bioinsight on production builds
    • Uncaught TypeError: Cannot read properties of undefined (reading 'random') at jstat.js:113:25

Screenshots

Fixed error in bioinsight:
image

@dvmartinweigl dvmartinweigl requested a review from a team as a code owner November 7, 2023 12:01
@dvmartinweigl dvmartinweigl self-assigned this Nov 7, 2023
@puehringer puehringer merged commit 2c25670 into develop Nov 7, 2023
@puehringer puehringer deleted the mw/pin_swc_core_to_1_3_95 branch November 7, 2023 13:48
@thinkh thinkh mentioned this pull request Nov 21, 2023
thinkh added a commit that referenced this pull request Nov 21, 2023
## What's Changed
* feat: ignore playwright folder in jest config by @puehringer in
#45
* deps: pin @swc/core to 1.3.95 by @dvmartinweigl in
#47
* feat: add ability to build ts|tsx from node_modules by @puehringer in
#46

## New Contributors
* @dvmartinweigl made their first contribution in
#47

**Full Changelog**:
v5.1.0...v6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants