Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-Handler: Ignore errors if the browser is outdated. Fixes #644 #1154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mal-tee
Copy link
Member

@mal-tee mal-tee commented Jun 18, 2024

No description provided.

Copy link

cypress bot commented Jun 18, 2024

datenanfragen/website    Run #6817

Run Properties:  status check passed Passed #6817  •  git commit 3c62b71ba6: add comment
Project datenanfragen/website
Branch Review m_deprecated_error
Run status status check passed Passed #6817
Run duration 03m 29s
Commit git commit 3c62b71ba6: add comment
Committer mal-tee
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 80
View all changes introduced in this branch ↗︎

@baltpeter
Copy link
Member

Thanks! But my concern is that we should only prevent users with unsupported browsers from reporting errors, not from seeing them. That would only lead to the site being inexplicably broken for them.

My suggestion would be to still show the modal but not the sections for reporting the error but instead display a warning that this is likely caused by an outdated browser.

@mal-tee
Copy link
Member Author

mal-tee commented Nov 8, 2024

Thanks! But my concern is that we should only prevent users with unsupported browsers from reporting errors, not from seeing them. That would only lead to the site being inexplicably broken for them.

But we are doing the same with extension users. Should we change the behaviour there as well? But I don't think we really want to support debugging weird extensions..

@baltpeter
Copy link
Member

The extension errors usually are meaningless for us (they only occur in the extensions' content scripts) and don't affect our site which continues to work fine.

That's not the case here, though. If the user's browser doesn't support the functions you check for, features on our site will break. If we don't show any notice to the user, the site will just be inexplicably broken for them. We should tell them that the error was caused by their outdated browser and that they need to switch to a supported browser to use our site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants