Escape parameter with CDATA

dauxio · May 11, 2023 · 68d9a27 · 68d9a27
1 parent 66638d8
commit 68d9a27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/libs/Format/Confluence/ContentTypes/Markdown/AdmonitionRenderer.php b/libs/Format/Confluence/ContentTypes/Markdown/AdmonitionRenderer.php
@@ -30,10 +30,13 @@ public function render(Node $node, ChildNodeRendererInterface $childRenderer): \
         $content = [];
 
         if ($node->getTitle()->hasChildren()) {
+
+            $title = $childRenderer->renderNodes($node->getTitle()->children());
+
             $content[] = new HtmlElement(
                 'ac:parameter',
                 ['ac:name' => 'title'],
-                $childRenderer->renderNodes($node->getTitle()->children())
+                str_contains($title, '<') ? '<![CDATA[' . $title. ']]>' : $title
             );
         }
 

diff --git a/tests/Format/Confluence/ContentTypes/Markdown/AdmonitionRendererTest.php b/tests/Format/Confluence/ContentTypes/Markdown/AdmonitionRendererTest.php
@@ -67,7 +67,7 @@ public function provideAdmonitionCases()
                         Sharing components across plugins is dangerous as they will be built with a version of React controlled in one plugin.
                     EOD,
                 <<<'EOD'
-                    <ac:structured-macro ac:name="warning"><ac:parameter ac:name="title">Use <code>&lt;ViewLoader&gt;</code> instead of sharing components across plugins</ac:parameter><ac:rich-text-body><p>Sharing components across plugins is dangerous as they will be built with a version of React controlled in one plugin.</p></ac:rich-text-body></ac:structured-macro>
+                    <ac:structured-macro ac:name="warning"><ac:parameter ac:name="title"><![CDATA[Use <code>&lt;ViewLoader&gt;</code> instead of sharing components across plugins]]></ac:parameter><ac:rich-text-body><p>Sharing components across plugins is dangerous as they will be built with a version of React controlled in one plugin.</p></ac:rich-text-body></ac:structured-macro>
                     EOD
 
             ]