Fix Issue 016: Date-only reminders preserve date-only after round-trip #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes to preserve date-only intent when syncing between Reminders and Vikunja: 1. createReminder() now uses task.dueIsDateOnly metadata from mapping table instead of re-detecting from string (which fails for Vikunja datetime strings) 2. vikunjaDateString() now uses local midnight (T00:00:00+HH:MM) instead of UTC midnight (T00:00:00Z), so Vikunja displays correct local date Also documents Issue 017: EventKit auto-populates startDateComponents when dueDateComponents is set (expected behavior, not a bug). Includes 4 new unit tests and integration test script. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to preserve date-only intent when syncing between Reminders and Vikunja:
createReminder() now uses task.dueIsDateOnly metadata from mapping table instead of re-detecting from string (which fails for Vikunja datetime strings)
vikunjaDateString() now uses local midnight (T00:00:00+HH:MM) instead of UTC midnight (T00:00:00Z), so Vikunja displays correct local date
Also documents Issue 017: EventKit auto-populates startDateComponents when dueDateComponents is set (expected behavior, not a bug).
Includes 4 new unit tests and integration test script.