Merge pull request #14 from ChristopherDavenport/changeSetReturnType

Change set return type to correctly handle Null byte string response
davenverse · Jan 11, 2021 · 8ad9bd7 · 8ad9bd7
2 parents c59eccd + fa65e12
commit 8ad9bd7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -19,7 +19,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
-      - uses: olafurpg/setup-scala@v7
+      - uses: olafurpg/setup-scala@v10
         with:
           java-version: ${{ matrix.java }}
       - name: Cache Coursier
@@ -45,7 +45,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: olafurpg/setup-scala@v5
+      - uses: olafurpg/setup-scala@v10
       - name: Cache Coursier
         uses: actions/cache@v1
         with:

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v1
         with:
           fetch-depth: 0
-      - uses: olafurpg/setup-scala@v5
+      - uses: olafurpg/setup-scala@v10
       - uses: olafurpg/setup-gpg@v2    
       - name: Cache Coursier
         uses: actions/cache@v1

diff --git a/.gitignore b/.gitignore
@@ -8,4 +8,5 @@ tags
 
 .bloop
 .metals
-project/metals.sbt
+metals.sbt
+.vscode
diff --git a/core/src/main/scala/io/chrisdavenport/rediculous/RedisCommands.scala b/core/src/main/scala/io/chrisdavenport/rediculous/RedisCommands.scala
@@ -133,7 +133,7 @@ object RedisCommands {
     val default = SetOpts(None, None, None, false)
   }
 
-  def set[F[_]: RedisCtx](key: String, value: String, setOpts: SetOpts = SetOpts.default): F[Status] = {
+  def set[F[_]: RedisCtx](key: String, value: String, setOpts: SetOpts = SetOpts.default): F[Option[Status]] = {
     val ex = setOpts.setSeconds.toList.flatMap(l => List("EX", l.encode))
     val px = setOpts.setMilliseconds.toList.flatMap(l => List("PX", l.encode))
     val condition = setOpts.setCondition.toList.map(_.encode)