Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of function execution in flaky test #75

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Hombre-x
Copy link
Contributor

@Hombre-x Hombre-x commented Jul 8, 2024

Solves #74

The tempDirectory function was outside the forall test, presumably creating race conditions inside it.

I ran the test for some time both in WSL and Ubuntu and I had no more failed tests so far, but in case that didn't solved the issue just let me know to try a different thing.

Now the function is inside the `forall` function

Also, inlined some definitions
Copy link
Member

@lenguyenthanh lenguyenthanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lenguyenthanh lenguyenthanh merged commit 6834129 into davenverse:main Jul 9, 2024
10 checks passed
@lenguyenthanh lenguyenthanh mentioned this pull request Jul 9, 2024
@TonioGela TonioGela deleted the test-fix branch July 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants