Change readLines behaviour when reading an empty last newline
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because readLines was modified, It now doesn't account the newline added by the writeLines method.
It now discards any empty characters after the last newline, just like the `wc` command in Unix Also, added tests to assert that behavior
I forgot that `tempFile` does not exist anymore
zetashift
approved these changes
Aug 24, 2024
TonioGela
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR id due to a small bug that I pointed to @lenguyenthanh and @TonioGela when creating the tutorial.
Basically, calling
Files[IO].writeUtf8Lines(path)will add a newline at the end of the written lines, regarding the number of elements of the collection. This will create a bug that, when usingFIles[IO].readlUtf8Lines(path)will always add a new empty element to the compiled collection at the end.So this PR changes the behaviour of the
readLinesmethod so it ignores any empty characters after the last newline, similar if you dowc -lon any file that has been written by theFiles#writeUtf8Linesmethod.It introduces changes on tests, as well as in the documentation.