Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow editing of *any* uploaded file #128

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Braindrop ChangeLog

## Unreleased

**Released: WiP**

- Extended the disabling of edits to any Raindrop associated with a file
that has been uploaded to `raindrop.io`. In testing it seems the data loss
happens with any Raindrop with an `up.raindrop.io` domain.
([#123](https://github.com/davep/braindrop/issues/123))

## v0.7.0

**Released: 2025-01-27**
Expand Down
11 changes: 6 additions & 5 deletions src/braindrop/app/screens/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,12 +674,13 @@ async def action_edit_raindrop_command(self) -> None:

# For the moment, don't allow editing of uploaded images.
# https://github.com/davep/braindrop/issues/123
if raindrop.type == "image":
if raindrop.domain == "up.raindrop.io":
self.notify(
"Editing of Raindrops that are images can cause the image to be lost. "
"While I investigate why this is I'm disabling the editing of any "
"Raindrop that is an image type.",
title="Editing if images is disabled",
"There seems to be a problem with the Raindrop API where, "
"if you modify a Raindrop associated with an uploaded file, "
"the uploaded file is lost.\n\n"
"To ensure your file isn't lost this edit is not permitted.",
title="Editing of uploads disabled",
severity="warning",
timeout=8,
)
Expand Down
Loading