Small bugfixes in exit code and unused_components (#102)

* Fixed bug with return code after running SOAR pipeline

The wrong error code was being returned, so now it’s not!

Signed-off-by: Dave Shanley <dshanley@splunk.com>

* unused_component rule upgraded

Now searches through polymorphic references, this was caught
after running the SOAR pipeline.

Signed-off-by: Dave Shanley <dshanley@splunk.com>

cmd/shared_functions.go

@@ -66,12 +66,12 @@ func CheckFailureSeverity(failSeverityFlag string, errors int, warnings int, inf
 	if failSeverityFlag != "error" {
 		switch failSeverityFlag {
 		case "warn":
-			if errors > 0 && warnings > 0 {
+			if warnings > 0 {
 				return fmt.Errorf("failed linting, with %d errors and %d warnings", errors, warnings)
 			}
 			return nil
 		case "info":
-			if errors > 0 && warnings > 0 && informs > 0 {
+			if informs > 0 {
 				return fmt.Errorf("failed linting, with %d errors, %d warnings and %d informs",
 					errors, warnings, informs)
 			}

functions/openapi/unused_component.go

@@ -43,6 +43,10 @@ func (uc UnusedComponent) RunRule(nodes []*yaml.Node, context model.RuleFunction
 	links := context.Index.GetAllLinks()
 	callbacks := context.Index.GetAllCallbacks()
 
+	for _, ref := range context.Index.GetPolyAllOfReferences() {
+		allRefs[ref.Definition] = ref
+	}
+
 	// if a component does not exist in allRefs, it was not referenced anywhere.
 	notUsed := make(map[string]*index.Reference)