Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usages of Printf in native runtime #503

Closed
davesnx opened this issue Aug 7, 2024 · 0 comments · Fixed by #511
Closed

Remove all usages of Printf in native runtime #503

davesnx opened this issue Aug 7, 2024 · 0 comments · Fixed by #511
Labels
runtime Issues related with styled-ppx's runtime

Comments

@davesnx
Copy link
Owner

davesnx commented Aug 7, 2024

Similar to what has been done in html_of_jsx or server-reason-react, we don't need to allocate the strings while concat... since it's just the output

References

ml-in-barcelona/server-reason-react#156
davesnx/html_of_jsx#18

@davesnx davesnx added the runtime Issues related with styled-ppx's runtime label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Issues related with styled-ppx's runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant