Use buffer to build stylesheet #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
davesnx
approved these changes
Sep 13, 2024
packages/runtime/native/CSS.ml
Outdated
| let render_declarations out rules = | ||
| let ls = rules |> Array.map ~f:Autoprefixer.prefix |> Array.flatten in | ||
| ls |> Array.iter ~f:(render_declaration out); | ||
| if Array.length ls > 0 then Buffer.truncate out (Buffer.length out - 1) |
packages/runtime/native/CSS.ml
Outdated
| let rules = rules_to_string rules in | ||
| push (Printf.sprintf "%s{%s}" selector rules) | ||
| let rules_to_string rules = | ||
| let out = Buffer.create 1024 in |
There was a problem hiding this comment.
Just an idea, instead of passing the buffer everywhere, what do you think about passing a ~push callback? Not suggesting to do the change, but rather to discuss if you see it better or worst.
There was a problem hiding this comment.
This could work, I guess the upside would be we are not dependent on Buffer.
Since we can push string and char, a possible solution would be using two callbacks ~pushc ~pushs, or maybe a polymorphic variant prop `string of string | `char of char ?
davesnx
approved these changes
Sep 15, 2024
pedrobslisboa
added a commit
to pedrobslisboa/styled-ppx
that referenced
this pull request
Oct 1, 2024
* origin/main: feat: add backdrop-filter to webkit (davesnx#510) Add unicodeRange to fontFace (davesnx#513) Use buffer to build stylesheet (davesnx#511) feat: add backdrop-filter to webkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #503 wohoo