Movement action in two phases for creatures with swift ability #244
Conversation
It works as I wrote in davewx7#242 issue. But I must admit long arrow is little confusing when a creature moves only one tile forward.
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I would suggest discussing the mechanic change at the Discord server and getting an approval there before developing any more changes for this pull request.
Even if the changes are perfect and so the pull request is approved, I won't be merging it before an approval for the change at the Discord server.
Related to this, I would recommend non obvious pull requests to be created out of feature branches, instead of the default branch.
data/classes/creature.cfg
Outdated
| do_move_internal(game, 2, direction), | ||
| do_move_internal(game, 1, direction) | ||
| ) | ||
| do_move_internal(game, 1, direction) |
There was a problem hiding this comment.
Exactly as you write:
[...] I must admit that a long arrow is little confusing when a creature moves only one tile forward.
Me too would prefer that the action of the creature matches the drawing of the arrow.
If we included this change verbatim, players would learn of this change not as a result of a new short arrow appearing instead of (or additionally to) the current long arrow. But as the result of the gotcha of expecting a double movement and getting a single movement.
As gotchas impact usability, I'm against merging this change. 🙁
There was a problem hiding this comment.
Thanks for tips. I didn't know about branch creating rule - I'm not a programmer. I must learn more how to use github more properly.
I have a question. If I create a new branch, will it be possible to move this pull request there.
Because I have other ideas - I know how to make the arrow short all the time, but must figure out how to place information about remaining/used movement points.
There was a problem hiding this comment.
I didn't know you can change the from branch of a pull request, but this article promises it is possible.
In case of any trouble with it, there is no problem in closing this pull request and referencing it from a new one for extended discussion.
Do as you please about this.
However, let me reassert, if any development changes can be categorized as rule changes, I will not be able to merge them even if the code seems alright.
Ponownie jednoetapowy ruch jednostek z zdolnościo swift.
1 participant
It works as I wrote in #242 issue.
But I must admit that a long arrow is little confusing when a creature moves only one tile forward.