Show loader upon submit #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I’m using Lucide to show a spinner on the Button on submit, specifically Loader2 do you have Lucide installed? |
|
Specifically, the action button with Log In or Sign Up changes to the Loader. The other buttons get “disabled” state. Which button specifically are you trying to show a loader for? |
|
The spinner doesn't work for the social auth. I saw the spinner is working for the email, password auth though |
|
I’ll fix that and merge it in a few hrs |
|
@mmikhan Just published 1.0.26 which will show the Action spinner on signIn with provider & passkey. LMK if this resolves the issue for you |
|
It does, thanks a lot 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liked your project a lot and decided to use it in a project. The first thing I have noticed is the loading spinner is missing upon submitting the form. Not sure if this is what you prefer but I always find it a good user feedback to show a loading spinner or some sort of status upon submitting a form in the in-between moment.
So, this PR adds a loading spinner and loading text upon submitting the auth form.
Note: I couldn't test it since you are using a custom version of better auth from your local disk. So, I am blindly submitting this PR. It might break stuff. So, please feel free to take a brief look at it, make the necessary changes (if needed) or discard if it's not up to the mark 🙏