Fixing a case where tests fail when the module is installed. Thanks t…

…o ppisar for GH#9
david-dick · Jan 3, 2025 · 0f7c6f3 · 0f7c6f3
1 parent 30e4ce7
commit 0f7c6f3
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -34,23 +34,25 @@ jobs:
         cpanm --installdeps .
         cpanm Test::CheckManifest
 
-      # RELEASE_TESTING is not enabled as some of the tests take way too long (more than 30 minutes)
     - name: Run tests under gmake (on windows)
       if: ${{ startsWith(matrix.runner, 'windows-') }}
+      env:
+        RELEASE_TESTING: 1
       run: |
         perl Makefile.PL
         gmake
         gmake test
+        gmake install
+        gmake test
 
     - name: Run tests under make (not windows)
       if: ${{ ! startsWith(matrix.runner, 'windows-') }}
+      env:
+        RELEASE_TESTING: 1
       run: |
         perl Makefile.PL
         make
         make test
+        make install
+        make test
 
-    - name: Run release tests
-      env:
-        RELEASE_TESTING: 1
-      run: |
-        prove t/manifest.t
diff --git a/t/core_partial_read.t b/t/core_partial_read.t
@@ -8,6 +8,7 @@ use Carp();
 use English qw( -no_match_vars );
 use Exporter();
 use XSLoader();
+use constant;
 
 SKIP: {
 	if ($^O eq 'MSWin32') {
@@ -17,9 +18,9 @@ SKIP: {
 		*CORE::GLOBAL::read = sub { return 0 };
 		*CORE::GLOBAL::sysread = sub { return 0 };
 		use warnings;
-		require POSIX;
 		my $required_error_message = quotemeta "Only read 0 bytes from";
-		@INC = grep !/blib\/arch/, @INC; # making sure we're testing pure perl version
+		require FileHandle;
+		@INC = qw(blib/lib); # making sure we're testing pure perl version
 		require Crypt::URandom;
 		my $generated = 0;
 		eval {

diff --git a/t/core_read.t b/t/core_read.t
@@ -8,6 +8,7 @@ use Carp();
 use English qw( -no_match_vars );
 use Exporter();
 use XSLoader();
+use constant;
 BEGIN {
 	if ($^O eq 'MSWin32') {
 		require Win32;
@@ -37,7 +38,8 @@ SKIP: {
 		use warnings;
 		require POSIX;
 		my $required_error_message = q[(?:] . (quotemeta POSIX::strerror(POSIX::EACCES())) . q[|Permission[ ]denied)];
-		@INC = grep !/blib\/arch/, @INC; # making sure we're testing pure perl version
+		require FileHandle;
+		@INC = qw(blib/lib); # making sure we're testing pure perl version
 		require Crypt::URandom;
 		my $generated = 0;
 		eval {

diff --git a/t/core_sysopen.t b/t/core_sysopen.t
@@ -8,6 +8,7 @@ use Carp();
 use English qw( -no_match_vars );
 use Exporter();
 use XSLoader();
+use constant;
 
 SKIP: {
 	if ($^O eq 'MSWin32') {
@@ -18,7 +19,8 @@ SKIP: {
 		use warnings;
 		require POSIX;
 		my $required_error_message = q[(?:] . (quotemeta POSIX::strerror(POSIX::EACCES())) . q[|Permission[ ]denied)];
-		@INC = grep !/blib\/arch/, @INC; # making sure we're testing pure perl version
+		require FileHandle;
+		@INC = qw(blib/lib); # making sure we're testing pure perl version
 		require Crypt::URandom;
 		my $generated = 0;
 		eval {

diff --git a/t/pp.t b/t/pp.t
@@ -5,7 +5,17 @@ use Carp();
 use English qw( -no_match_vars );
 use Exporter();
 use XSLoader();
-@INC = grep !/blib\/arch/, @INC; # making sure we're testing pure perl version
+use constant;
+BEGIN {
+	if ($^O eq 'MSWin32') {
+		require Win32;
+		require Win32::API;
+		require Win32::API::Type;
+	} else {
+		require FileHandle;
+	}
+}
+@INC = qw(blib/lib); # making sure we're testing pure perl version
 require Crypt::URandom;
 
 foreach my $correct (qw(500000 500 50)) {