Standardize z-index usage across components #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the development philosophy to include a rule against starting servers directly. This is to ensure that the development environment is consistent and that all server interactions are managed through the appropriate channels.
Introduces a structured development process centered around the decomposition of GitHub issues into manageable, vertical-slice sub-tasks. This includes: - A sub-issue template to ensure clarity and consistency. - A workflow guide for junior developers. - A prompt for senior developers to facilitate issue decomposition.
Adds a new prompt, 'prompts/logical_commit_workflow.md', that defines a rigorous, verification-based process for committing changes. This workflow ensures that all changes are analyzed and grouped into distinct, logical commits based on their content and purpose, rather than on assumptions.
david
force-pushed
the
feature/standardize-z-index
branch
from
1d93da1 to
674c1b9
Compare
david
commented
Jul 30, 2025
| <.drawer show={false} /> | ||
| <.bottom_dock current_scope={@current_scope} /> | ||
| </div> | ||
| <div id="sidebar-container" class="drawer-side z-80" phx-hook="Sidebar"> |
Owner
Author
There was a problem hiding this comment.
If this was previously at z-80, why did you use z-drawer, rather than z-modal?
david
commented
Jul 30, 2025
|
|
||
| def hamburger_button(assigns) do | ||
| ~H""" | ||
| <label for="sidebar-drawer" class="btn btn-ghost mx-1 px-2 z-100 print:hidden"> |
david
commented
Jul 30, 2025
lib/cms_web/components/settings.ex
Outdated
| <div | ||
| id="settings-drawer" | ||
| class={"print:hidden fixed bottom-0 left-0 right-0 bg-base-200 p-4 pb-20 transform transition-transform duration-300 ease-in-out z-30" <> if(@show, do: " translate-y-0", else: " translate-y-full")} | ||
| class={"print:hidden fixed bottom-0 left-0 right-0 bg-base-200 p-4 pb-20 transform transition-transform duration-300 ease-in-out z-drawer" <> if(@show, do: " translate-y-0", else: " translate-y-full")} |
Owner
Author
There was a problem hiding this comment.
Shouldn't this be z-sticky?
david
force-pushed
the
feature/standardize-z-index
branch
from
674c1b9 to
ca0a22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41