Using correct ICC profile while exporting Webp Images #410
Conversation
|
closes #384 |
|
I'm sorry @prashik-s but the test seems to be failing |
This reverts commit 5c0bc15.
|
Sorry for the hassle. I had to revert the merge |
|
I'm not sure what's wrong but the test didn't even execute. It failed even before this step |
|
Can you resubmit the PR? You can see the failed test in the main branch commit, not on your PR
|
|
you can see test run #560: `vips cac image_test.go:75: --- FAIL: TestImageInbuildIcc_WebP (0.38s) |
|
Hey, I ran into a similar issue with ICC profiles. When converting a P3 Display image using the vips CLI command func convertToWebP(image *vips.ImageRef, quality int) (imageBytes []byte, err error) {
options := vips.NewWebpExportParams()
options.ReductionEffort = 4
options.Quality = quality
imageBytes, _, err = image.ExportWebp(options)
if err != nil {
return nil, fmt.Errorf("error exporting to webp: %w", err)
}
return imageBytes, nil
}Both output images are 1.29MB. |
…byttow#410)" (davidbyttow#412) This reverts commit 48c3867.
…byttow#410)" (davidbyttow#412) This reverts commit 48c3867.
…byttow#410)" (davidbyttow#412) This reverts commit 48c3867.
No description provided.