-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow openairmaps to auto-detect certain limits (e.g., polarMap(limits = ...)
)
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds option to auto-detect a shared colour scale
Adds option to `polarMap()` to ensure all markers have the same radial axis limits.
Currently "fixed" does not fully work owing to openair limitations
Adds auto-detecting breaks to the freqMap function.
Errors inherited from `{openair}`
jack-davison
added
enhancement
New features
map:polar 🧭
Anything to do with polar marker maps, e.g., polarMap()
ggmap 📊
labels
Jul 31, 2023
jack-davison
added a commit
that referenced
this pull request
Aug 8, 2024
Feature: Allow openairmaps to auto-detect certain limits (e.g., `polarMap(limits = ...)`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #34.
In short, it changes up how
limits
and similar args are handled to allowpolarMap()
and friends to automatically detect limits.Created on 2023-07-31 with reprex v2.0.2