-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine dynamic and static polar plotting functions #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'feat/combine-polars' of https://github.com/davidcarslaw/openairmaps into feat/combine-polars # Conflicts: # R/polar_annulusMap.R
use `type` over `control`/`facet`
jack-davison
added a commit
that referenced
this pull request
Aug 8, 2024
Combine dynamic and static polar plotting functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #59, but evolved considerably from it.
In short, it deprecates
polarMapStatic()
in favour of astatic = TRUE
argument onpolarMap()
.There are a few (I think) good reasons for doing this:
{openair}
, which arguably prefers fewer functions with more arguments over more functions with fewer arguments.The evolution of this has extended to:
type
across nearly all functions (e.g.,trajMap()
).type
is always passed toopenair::cutData()
(was not intrajMapStatic()
).buildPopup()
Created on 2024-04-15 with reprex v2.0.2