feat(bailout): flag bailout as a panic function

davidcole1340 · Oct 21, 2023 · 6679f5f · 6679f5f
1 parent ba342c4
commit 6679f5f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/ffi.rs b/src/ffi.rs
@@ -31,7 +31,7 @@ extern "C" {
         ctx: *const c_void,
         result: *mut *mut c_void,
     ) -> bool;
-    pub fn ext_php_rs_zend_bailout();
+    pub fn ext_php_rs_zend_bailout() -> !;
 }
 
 include!(concat!(env!("OUT_DIR"), "/bindings.rs"));
diff --git a/src/zend/try_catch.rs b/src/zend/try_catch.rs
@@ -64,7 +64,7 @@ pub fn try_catch<R, F: FnMut() -> R + RefUnwindSafe>(func: F) -> Result<R, Catch
 ///
 /// When using this function you should ensure that all the memory allocated in the current scope is released
 ///
-pub unsafe fn bailout() {
+pub unsafe fn bailout() -> ! {
     ext_php_rs_zend_bailout();
 }
 
@@ -83,7 +83,10 @@ mod tests {
                     bailout();
                 }
 
-                assert!(false);
+                #[allow(unreachable_code)]
+                {
+                    assert!(false);
+                }
             });
 
             assert!(catch.is_err());
@@ -108,7 +111,10 @@ mod tests {
                 bailout();
             }
 
-            assert!(false);
+            #[allow(unreachable_code)]
+            {
+                assert!(false);
+            }
         });
     }