Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pipeline #320

Merged
merged 1 commit into from
Oct 20, 2024
Merged

ci: fix pipeline #320

merged 1 commit into from
Oct 20, 2024

Conversation

Xenira
Copy link
Collaborator

@Xenira Xenira commented Aug 7, 2024

Fixed ci as discussed in #315

Also had to fix clippy rules that changed and made master fail.

Copy link
Collaborator

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me maybe an extra eye from @danog ?

@danog
Copy link
Collaborator

danog commented Aug 8, 2024

Not a super fan of removing platform tests tbh, I see that no one has contributed a mac build for clang 18 to the official llvm repo, but maybe there's some other source that could be used for the binaries? Don't have a Mac, but it seems brew offers a clang 18 build...

@Xenira
Copy link
Collaborator Author

Xenira commented Aug 10, 2024

Just added a clang --version to this and it seems to build with Apple clang version 15.0.0 (clang-1500.3.9.4) (https://github.com/Xenira/ext-php-rs-pipeline-debug/actions/runs/10329884456/job/28598214318#step:10:15).

Adding clang 18 is something I would do in #318.

Apple builds itself are not skipped, They just use the builtin clang (same as Windows), which is the better test imo as that better replicates a user trying to build on their system.

@Xenira
Copy link
Collaborator Author

Xenira commented Sep 16, 2024

Hey, would like to get this moving again. Imo we should get the ci working again with as few changes as possible and then focus on getting clang 18 support.
@danog

Copy link
Owner

@davidcole1340 davidcole1340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@davidcole1340 davidcole1340 merged commit 75ed264 into davidcole1340:master Oct 20, 2024
26 checks passed
@Xenira Xenira mentioned this pull request Nov 28, 2024
@Xenira Xenira deleted the fix-ci branch December 2, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants