Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

davidcole1340 / ext-php-rs Public

Notifications You must be signed in to change notification settings
Fork 67
Star 621

Code
Issues 50
Pull requests 14
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Explicit preparation phase without STATE#333

Open

faassen wants to merge 11 commits intodavidcole1340:masterdavidcole1340/ext-php-rs:masterfrom faassen:explicitfaassen/ext-php-rs:explicitCopy head branch name to clipboard

+281-206

Conversation Commits11 (11)Checks Files changed

Commits

Commits on Oct 21, 2024

Don't use symbolic links for git.
faassen
committed
Preparatory: factor out generate_class so we can later call it earlier.
faassen
committed

Commits on Oct 22, 2024

function::parse doesn't need to return a tuple
faassen
committed
Call it class_tokenstream which is a bit more clear.
faassen
committed
Factor out a stateless prepare function from the parser function.
faassen
committed
Pull stateless prepare out of class construction.
faassen
committed
A tricky refactor to pull out state.
faassen
committed
Factor out stateless stuff from startup function.
faassen
committed
Factor out prepare from impl.
faassen
committed
It's nicer to have the check that the class is there yet earlier as it's state related.
faassen
committed
It's almost not worth it here, but factor out preparation from token stream generation.
faassen
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.