Skip to content

fix: Prevent lowercase enums #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davidgrayston-paddle wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Prevent lowercase enums #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions paddle_billing/PaddleStrEnum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ def __getattr__(cls, name):
if _is_dunder(name):
raise AttributeError(name)

if isinstance(name, str) and name.islower():
raise AttributeError(name)

return cls(str(name).lower())


Expand Down
20 changes: 20 additions & 0 deletions tests/Unit/PaddleStrEnum/test_PaddleStrEnum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,23 @@ class TestCountryCodesEnum(PaddleStrEnum, metaclass=PaddleStrEnumMeta):
assert TestCountryCodesEnum.France.value == "france"
assert TestCountryCodesEnum.France.name == "Undefined"
assert not TestCountryCodesEnum.France.is_known()
assert hasattr(TestCountryCodesEnum, "France") is True


def test_paddle_str_enum_does_not_support_lowercase_attributes():
class TestCountryCodesEnum(PaddleStrEnum, metaclass=PaddleStrEnumMeta):
CA: "TestCountryCodesEnum" = "canada"
US: "TestCountryCodesEnum" = "usa"

# Contain uppercase letters.
assert hasattr(TestCountryCodesEnum, "SomeCountry") is True
assert hasattr(TestCountryCodesEnum, "Some Country") is True
assert hasattr(TestCountryCodesEnum, "Some-Country") is True
assert hasattr(TestCountryCodesEnum, "Some_Country") is True
assert hasattr(TestCountryCodesEnum, "SOMECOUNTRY") is True
assert hasattr(TestCountryCodesEnum, "SOME_COUNTRY") is True

# Lowercase only.
assert hasattr(TestCountryCodesEnum, "somecountry") is False
assert hasattr(TestCountryCodesEnum, "some_country") is False
assert hasattr(TestCountryCodesEnum, "some-country") is False
Loading