Perf issue fix: avoid creating an inject plugin when there are no shims to inject #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using
vite-plugin-node-polyfills
on a fairly large vite project and it madevite build
slower by 50-100%. It also caused increased memory usage (causing OOM errors).I tracked down the source of the slowdown to the
inject
plugin. My config hadglobals.{Buffer, global, process}
all set tofalse
so the plugin was not necessary.I reworked the logic to avoid passing in the inject plugin when there are no shims to inject.