Skip to content

Commit

Permalink
changed show_plots to show_graphs (conflicting short arguments)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidpagnon committed Sep 5, 2024
1 parent 4c52de8 commit 78d462c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ sports2d --help
```
- Run with custom parameters (all non specified are set to default):
``` cmd
sports2d --show_plots False --time_range 0 2.1 --result_dir path_to_result_dir
sports2d --show_graphs False --time_range 0 2.1 --result_dir path_to_result_dir
```
``` cmd
sports2d --multiperson false --mode lightweight --det_frequency 50
Expand Down
4 changes: 2 additions & 2 deletions Sports2D/Sports2D.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
- Run on webcam with default parameters:
sports2d --video_input webcam
- Run with custom parameters (all non specified are set to default):
sports2d --show_plots False --time_range 0 2.1 --result_dir path_to_result_dir
sports2d --show_graphs False --time_range 0 2.1 --result_dir path_to_result_dir
sports2d --multiperson false --mode lightweight --det_frequency 50
- Run with a toml configuration file:
sports2d --config path_to_config.toml
Expand Down Expand Up @@ -407,7 +407,7 @@ def main():
- Run on webcam with default parameters:
sports2d --video_input webcam
- Run with custom parameters (all non specified are set to default):
sports2d --show_plots False --time_range 0 2.1 --result_dir path_to_result_dir
sports2d --show_graphs False --time_range 0 2.1 --result_dir path_to_result_dir
sports2d --multiperson false --mode lightweight --det_frequency 50
- Run with a toml configuration file:
sports2d --config path_to_config.toml
Expand Down
6 changes: 3 additions & 3 deletions Sports2D/Utilities/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ def test_workflow():
config_dict = toml.load(python_config_path)
config_dict.get("project").update({"video_dir":'../Demo'})
config_dict.get("process").update({"show_realtime_results":False})
config_dict.get("post-processing").update({"show_plots":False})
config_dict.get("post-processing").update({"show_graphs":False})

from Sports2D import Sports2D
Sports2D.process(config_dict)


# From command line (CLI)
demo_cmd = ["sports2d", "--show_realtime_results", "False", "--show_plots", "False"]
demo_cmd = ["sports2d", "--show_realtime_results", "False", "--show_graphs", "False"]
subprocess.run(demo_cmd, check=True, capture_output=True, text=True)


Expand All @@ -58,5 +58,5 @@ def test_workflow():
config_dict.get("project").update({"video_dir": str(cli_video_dir)})
with open(cli_config_path, 'w') as f: toml.dump(config_dict, f)

demo_config_cmd = ["sports2d", "--config", str(cli_config_path), "--show_realtime_results", "False", "--show_plots", "False"]
demo_config_cmd = ["sports2d", "--config", str(cli_config_path), "--show_realtime_results", "False", "--show_graphs", "False"]
subprocess.run(demo_config_cmd, check=True, capture_output=True, text=True)
2 changes: 1 addition & 1 deletion Sports2D/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,7 @@ def process_fun(config_dict, video_file, time_range, frame_rate, result_dir):
fill_large_gaps_with = config_dict.get('post-processing').get('fill_large_gaps_with')

do_filter = config_dict.get('post-processing').get('filter')
show_plots = config_dict.get('post-processing').get('show_plots')
show_plots = config_dict.get('post-processing').get('show_graphs')
filter_type = config_dict.get('post-processing').get('filter_type')
butterworth_filter_order = config_dict.get('post-processing').get('butterworth').get('order')
butterworth_filter_cutoff = config_dict.get('post-processing').get('butterworth').get('cut_off_frequency')
Expand Down

0 comments on commit 78d462c

Please sign in to comment.