Open
Conversation
This is working with the changes to the HTTP server, but has not been refined at all.
Signed-off-by: David Pastl <david.pastl@lightsource.ca>
Breaking out existing unit tests into separate files for readability. Added OIDC unit tests.
The workflow had names, but for some reason on github each workflow didn't follow that name. Thsi attempts to fix that and make it easier to see what each workflow did.
This dramatically speeds up unit tests, from around 1.5h to 10 minutes by running multiple docker containers in parallel as workers. This is almost certainly not the most optimzied way of doing this, but I found it useful to reduce test times.
Adding support for OIDC logins
Updated the docs to include instructions on how to build this project locally, along with how to use the new parallel run tool I added. Added / updated the parallel CI run tool. This was dropping the unit test run times from hours to around 9 minutes for unit tests on a single python version, or around 30 minutes when testing all possible python versions. Added a fix for a failing unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements support for external logins, primarily OIDC based in a way that is transparent to other methods of using the API. It includes new unit tests, documentation, and some scripts to reduce local test times as much as possible.
Motivation and Context
This is a part of the work to implement OIDC auth flows into the httpserver, providing the api side of that change.
Summary of Changes for Release Notes
Fixed
Added
Changed
Removed
How Has This Been Tested?
This was tested against the http server application.