Skip to content

Commit

Permalink
[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (
Browse files Browse the repository at this point in the history
…elastic#193798)

A variable for the page height was not being calculated correctly when
the Kibana chrome is invisible. This PR fixes the issue by adding `px`
as a unit to a variable used as input in the calculation.

Unblocks: elastic#193647

## Testing
It will help to test within the
elastic#193647 PR branch. The following
screenshots show the before and after effects of having this fix:

**before**

![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)

**after**

![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
  • Loading branch information
3 people authored Oct 4, 2024
1 parent 102297c commit 1df458d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/core/public/styles/rendering/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@
}

.kbnBody--chromeHidden {
--euiFixedHeadersOffset: 0;
// stylelint-disable-next-line length-zero-no-unit
--euiFixedHeadersOffset: 0px;

&.kbnBody--hasHeaderBanner {
--euiFixedHeadersOffset: var(--kbnHeaderBannerHeight);
Expand Down

0 comments on commit 1df458d

Please sign in to comment.