-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support secure connection with custom certificates #125
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 99.08% 99.02% -0.06%
==========================================
Files 30 30
Lines 1639 1642 +3
==========================================
+ Hits 1624 1626 +2
- Misses 15 16 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 98.45% 98.39% -0.06%
==========================================
Files 29 29
Lines 1614 1617 +3
==========================================
+ Hits 1589 1591 +2
- Misses 25 26 +1
Continue to review full report at Codecov.
|
@larryzhao Hey there, are you still working on this or is this ready for a review? |
@davissp14 yes, I think it's ok for a review. I am now running it on my production. Sorry for the codecov. Actually I am a little bit confused about this coverage check, I tried to fix it up but just don't understand where I should fix to make it up to 100% . |
@larryzhao Good stuff. I'll do my best to take a look soon. |
custom_certificates
in the initialization options ofEtcdv3
custom_certificates
down toConnection
to initialize ChannelGRPC::Core::ChannlCertificates
since the certs variables are locked C layer.