Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment prerelease #135

Merged
merged 27 commits into from
Jul 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1af8391
Fix: Logical properties regression in preview [ED-11366] (#23071)
rami-elementor Jul 16, 2023
f80727e
Fix: App-Bar Primary Action Min Width [ED-11379] (#23066)
rotemee Jul 16, 2023
b39a35d
Fix: Responsive settings for Section Templates wont fully save [ED-11…
maork-elementor Jul 16, 2023
95d311e
Internal: Added responsive template tests [ED-10605] (#23065)
Jul 17, 2023
07eeec0
Fix: Import Export - clean data leftover due to a failure in the proc…
Jul 17, 2023
b434daa
Internal: [NA] Tests task - Create E2E tests [ED-11088] (#22865)
Barcov Jul 17, 2023
9071497
Internal: Add hooks to support performance tests (#23054)
Nevoss Jul 17, 2023
71a060d
Internal: Fix NA E2E Tests [ED-11431] (#23088)
Barcov Jul 17, 2023
64cdac4
Internal: Remove the default 'wrap=on' option [ED-10455] (#23091)
davseve Jul 18, 2023
ffc8c4b
Tweak: Added Stroke and Shadow options to Accordion titles [ED-11395]…
davseve Jul 18, 2023
8bee80d
Fix: Setting the Direction to Row horizontal or Row reversed breaks t…
louiswol94 Jul 18, 2023
983640e
Internal: Editor V2 - Change global variable name [ED-11296] (#23079)
rotemee Jul 18, 2023
403b1e2
Tweak: Improve render issue when changing title name in Accordion wid…
Barcov Jul 18, 2023
255e40d
Fix: Background slideshow in Carousel [ED-11415] (#23108)
hein-obox Jul 19, 2023
b5c835d
Fix: Old widget panel header appears when when Editor Top Bar feature…
Nevoss Jul 19, 2023
8730afe
New: Apps page [ED-11068] (#23106)
KingYes Jul 19, 2023
2425737
Internal: Fix links [ED-11313] (#23111)
arielk Jul 19, 2023
d2c1cec
Tweak: Wrap Pages Panel in experiment [ED-11346] (#23000)
lenalElementor Jul 20, 2023
28142e3
Revert "Fix: Background slideshow in Carousel [ED-11415]" (#23117)
louiswol94 Jul 20, 2023
59e1d03
Fix: Responsive control of width Offset Sides [ED-11390] (#23115)
ArmanPurtoian Jul 20, 2023
566394d
Tweak: Replace CSS `float` with other layouts [ED-11340] (#23001)
rami-elementor Jul 20, 2023
9579a5d
New: Internal: Add Grid Container icon to eicons [ED-11432] (#23120)
louiswol94 Jul 20, 2023
9f79436
Tweak: Use CSS logical properties in border-radius [ED-11392] (#23052)
rami-elementor Jul 20, 2023
17431a6
Fix: Duplicate item is not working as expected in Accordion widget [E…
mykytamurzin Jul 21, 2023
769c244
Revert "Tweak: Wrap Pages Panel in experiment [ED-11346]" (#23142)
lenalElementor Jul 23, 2023
0a15c43
Merge branch 'main' into internal/ED-11261-one-click-cloud-release
davseve Jul 23, 2023
36e2410
comment prerelease option
davseve Jul 23, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/one-click-hosting-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ jobs:
elementor-*.zip
${{ env.CHANGELOG_FILE }}
# Will be removed once we see that the release is working
prerelease: true
# prerelease: true
body_path: ${{ env.CHANGELOG_FILE }}
- name: Post To Slack Created Cloud daily automated Release
- name: Post To Slack Created Cloud one click Release
uses : ./.github/workflows/post-to-slack
with:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_TOKEN }}
Expand Down
9 changes: 8 additions & 1 deletion .grunt-config/sass.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const sass = {
},
{
expand: true,
cwd: 'core/editor/assets/scss',
cwd: 'core/editor/loader/v2/scss',
src: '*.scss',
dest: 'assets/css',
ext: '.css'
Expand Down Expand Up @@ -70,6 +70,13 @@ const sass = {
dest: 'assets/css/modules/ai',
ext: '.css',
},
{
expand: true,
cwd: 'modules/apps/assets/scss',
src: 'admin.scss',
dest: 'assets/css/modules/apps',
ext: '.css',
},
]
}
};
Expand Down
4 changes: 2 additions & 2 deletions .grunt-config/webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ const externals = {
'@elementor/hooks': 'elementorAppPackages.hooks',
'@elementor/site-editor': 'elementorAppPackages.siteEditor',
'@elementor/router': 'elementorAppPackages.router',
'@elementor/ui': '__UNSTABLE__elementorPackages.ui',
'@elementor/icons': '__UNSTABLE__elementorPackages.icons',
'@elementor/ui': 'elementorV2.ui',
'@elementor/icons': 'elementorV2.icons',
};

const plugins = [
Expand Down
8 changes: 4 additions & 4 deletions .grunt-config/webpack.packages.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,18 @@ const common = {
),
plugins: [
new GenerateWordPressAssetFileWebpackPlugin( {
handle: ( entryName ) => `elementor-packages-${entryName}`,
handle: ( entryName ) => `elementor-v2-${entryName}`,
map: [
{ request: /^@elementor\/(.+)$/, handle: 'elementor-packages-$1' },
{ request: /^@elementor\/(.+)$/, handle: 'elementor-v2-$1' },
{ request: /^@wordpress\/(.+)$/, handle: 'wp-$1' },
{ request: 'react', handle: 'react' },
{ request: 'react-dom', handle: 'react-dom' },
]
} ),
new ExternalizeWordPressAssetsWebpackPlugin( {
global: ( entryName ) => [ '__UNSTABLE__elementorPackages', entryName ],
global: ( entryName ) => [ 'elementorV2', entryName ],
map: [
{ request: /^@elementor\/(.+)$/, global: [ '__UNSTABLE__elementorPackages', '$1' ] },
{ request: /^@elementor\/(.+)$/, global: [ 'elementorV2', '$1' ] },
{ request: /^@wordpress\/(.+)$/, global: [ 'wp', '$1' ] },
{ request: 'react', global: 'React' },
{ request: 'react-dom', global: 'ReactDOM' },
Expand Down
4 changes: 4 additions & 0 deletions app/modules/import-export/module.php
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,10 @@ private function maybe_handle_ajax() {
break;
}
} catch ( \Error $e ) {
if ( isset( $this->import ) ) {
$this->import->finalize_import_session_option();
}

Plugin::$instance->logger->get_logger()->error( $e->getMessage(), [
'meta' => [
'trace' => $e->getTraceAsString(),
Expand Down
14 changes: 9 additions & 5 deletions app/modules/import-export/processes/import.php
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ private function set_import_object( array $instance ) {
* @throws \Exception
*/
public static function from_session( string $session_id ): Import {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS );
$import_sessions = Utils::get_import_sessions();

if ( ! $import_sessions || ! isset( $import_sessions[ $session_id ] ) ) {
throw new \Exception( 'Couldn’t execute the import process because the import session does not exist.' );
Expand Down Expand Up @@ -397,7 +397,7 @@ public function run_runner( string $runner_name ): array {
* @return void
*/
public function init_import_session( $save_instance_data = false ) {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS );
$import_sessions = Utils::get_import_sessions( true );

$import_sessions[ $this->session_id ] = [
'session_id' => $this->session_id,
Expand Down Expand Up @@ -765,7 +765,7 @@ private function save_elements_of_imported_posts() {
}

private function update_instance_data_in_import_session_option() {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS );
$import_sessions = Utils::get_import_sessions();

$import_sessions[ $this->session_id ]['instance_data']['documents_data'] = $this->documents_data;
$import_sessions[ $this->session_id ]['instance_data']['imported_data'] = $this->imported_data;
Expand All @@ -774,8 +774,12 @@ private function update_instance_data_in_import_session_option() {
update_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS, $import_sessions, false );
}

private function finalize_import_session_option() {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS );
public function finalize_import_session_option() {
$import_sessions = Utils::get_import_sessions();

if ( ! isset( $import_sessions[ $this->session_id ] ) ) {
return;
}

unset( $import_sessions[ $this->session_id ]['instance_data'] );

Expand Down
18 changes: 12 additions & 6 deletions app/modules/import-export/processes/revert.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Elementor\App\Modules\ImportExport\Runners\Revert\Taxonomies;
use Elementor\App\Modules\ImportExport\Runners\Revert\Templates;
use Elementor\App\Modules\ImportExport\Runners\Revert\Wp_Content;
use Elementor\App\Modules\ImportExport\Utils;

class Revert {

Expand Down Expand Up @@ -57,25 +58,30 @@ public function run() {
throw new \Exception( 'Couldn’t execute the revert process because no revert runners have been specified. Try again by specifying revert runners.' );
}

$data = $this->get_last_import_session();
$import_session = $this->get_last_import_session();

if ( empty( $data ) ) {
if ( empty( $import_session ) ) {
throw new \Exception( 'Couldn’t execute the revert process because there are no import sessions to revert.' );
}

// fallback if the import session failed and doesn't have the runners metadata
if ( ! isset( $import_session['runners'] ) && isset( $import_session['instance_data'] ) ) {
$import_session['runners'] = $import_session['instance_data']['runners_import_metadata'] ?? [];
}

foreach ( $this->runners as $runner ) {
if ( $runner->should_revert( $data ) ) {
$runner->revert( $data );
if ( $runner->should_revert( $import_session ) ) {
$runner->revert( $import_session );
}
}

$this->revert_attachments( $data );
$this->revert_attachments( $import_session );

$this->delete_last_import_data();
}

public static function get_import_sessions() {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS );
$import_sessions = Utils::get_import_sessions();

if ( ! $import_sessions ) {
return [];
Expand Down
18 changes: 18 additions & 0 deletions app/modules/import-export/utils.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,22 @@ public static function transform_name_to_title( $name ): string {

return ucwords( $title );
}

public static function get_import_sessions( $should_run_cleanup = false ) {
$import_sessions = get_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS, [] );

if ( $should_run_cleanup ) {
foreach ( $import_sessions as $session_id => $import_session ) {
if ( ! isset( $import_session['runners'] ) && isset( $import_session['instance_data'] ) ) {
$import_sessions[ $session_id ]['runners'] = $import_session['instance_data']['runners_import_metadata'] ?? [];

unset( $import_sessions[ $session_id ]['instance_data'] );
}
}

update_option( Module::OPTION_KEY_ELEMENTOR_IMPORT_SESSIONS, $import_sessions );
}

return $import_sessions;
}
}
1 change: 0 additions & 1 deletion assets/dev/js/editor/utils/container-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ export class ContainerHelper {
case 'c100-c50-50': {
settings = {
flex_direction: ContainerHelper.DIRECTION_ROW,
flex_wrap: 'wrap',
flex_gap: {
unit: 'px',
size: 0, // Set the gap to 0 to override the default inherited from `Site Settings`.
Expand Down
13 changes: 10 additions & 3 deletions assets/dev/js/frontend/handlers/base-carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,20 @@ export default class CarouselHandlerBase extends SwiperHandlerBase {
return swiperOptions;
}

getOffsetWidth() {
const currentDevice = elementorFrontend.getCurrentDeviceMode();
return elementorFrontend.utils.controls.getResponsiveControlValue( this.getElementSettings(), 'offset_width', 'size', currentDevice ) || 0;
}

applyOffsetSettings( elementSettings, swiperOptions, slidesToShow ) {
const offsetSide = elementSettings.offset_sides;
const isNestedCarouselInEditMode = elementorFrontend.isEditMode() && 'NestedCarousel' === this.constructor.name;
const offsetSide = elementSettings.offset_sides,
isNestedCarouselInEditMode = elementorFrontend.isEditMode() && 'NestedCarousel' === this.constructor.name;

if ( isNestedCarouselInEditMode || ! offsetSide || 'none' === offsetSide ) {
return;
}

const offset = elementSettings.offset_width.size;
const offset = this.getOffsetWidth();

switch ( offsetSide ) {
case 'right':
Expand Down Expand Up @@ -207,13 +212,15 @@ export default class CarouselHandlerBase extends SwiperHandlerBase {
this.elements.$paginationWrapper.on( 'keydown', '.swiper-pagination-bullet', this.onDirectionArrowKeydown.bind( this ) );
this.elements.$swiperContainer.on( 'keydown', '.swiper-slide', this.onDirectionArrowKeydown.bind( this ) );
this.$element.find( ':focusable' ).on( 'focus', this.onFocusDisableAutoplay.bind( this ) );
elementorFrontend.elements.$window.on( 'resize', this.getSwiperSettings.bind( this ) );
}

unbindEvents() {
this.elements.$swiperArrows.off();
this.elements.$paginationWrapper.off();
this.elements.$swiperContainer.off();
this.$element.find( ':focusable' ).off();
elementorFrontend.elements.$window.off( 'resize' );
}

onDirectionArrowKeydown( event ) {
Expand Down
10 changes: 8 additions & 2 deletions assets/dev/scss/admin/_beta-tester.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,21 @@
margin-block-start: 30px;

.elementor-button {
border-radius: getValueByDirection(0 3px 3px 0, 3px 0 0 3px);
border-start-start-radius: 0;
border-start-end-radius: 3px;
border-end-start-radius: 0;
border-end-end-radius: 3px;
}
}

&__email {
flex-grow: 1;
border: var(--e-a-border);
border-inline-end: 0;
border-radius: getValueByDirection(3px 0 0 3px, 0 3px 3px 0);
border-start-start-radius: 3px;
border-start-end-radius: 0;
border-end-start-radius: 3px;
border-end-end-radius: 0;
margin: 0;
padding: 10px;
height: 50px;
Expand Down
7 changes: 4 additions & 3 deletions assets/dev/scss/admin/_feedback.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
}

.elementor-deactivate-feedback-dialog-input {
float: $start;
margin-block: 0;
margin-inline: 0 15px;
box-shadow: none;
Expand Down Expand Up @@ -125,11 +124,13 @@

&-form-body {
padding-block-start: 30px;
padding-block-end: 15px;
}
}

.elementor-deactivate-feedback-dialog-input-wrapper {
line-height: 1;
display: flex;
align-items: center;
line-height: 2;
overflow: hidden;
margin-block-end: 15px;
}
26 changes: 0 additions & 26 deletions assets/dev/scss/admin/_system_info.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@
.elementor-system-info-section {
margin-block-end: 10px;

& > .elementor-system-info-report-name {
padding-inline-start: 10px;
border-block-end: 1px solid #e1e1e1;
}

.widefat {
white-space: pre;
}
Expand All @@ -29,32 +24,11 @@
}
}

.elementor-system-info-report-name {
text-transform: uppercase;
font-size: 14px;
margin: 0;
line-height: 2;
}

.elementor-system-info-report-row {
overflow: hidden;
padding: 5px 0;

> * {
float: $start;
}
}

.elementor-system-info-report-field,
.elementor-system-info-field-recommendation {
padding-inline-start: 10px;
color: #7F7F7F;
}

.elementor-system-info-report-fields {
padding-inline-start: 20px;
}

.elementor-system-info-plugin-name {
color: #000;
}
Expand Down
3 changes: 1 addition & 2 deletions assets/dev/scss/common/_dialog-templates.scss
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@
font-size: 11px;
font-weight: normal;
line-height: 1;
text-transform: uppercase;
border-radius: 2px;
border-radius: var(--e-a-border-radius);
cursor: pointer;

> i {
Expand Down
1 change: 0 additions & 1 deletion assets/dev/scss/common/_notifications.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
font-size: 12px;
font-weight: 500;
line-height: 1.2;
text-transform: uppercase;
padding: 8px 16px;
@include margin-end(10px);
color: var(--e-a-dark-color-txt);
Expand Down
1 change: 0 additions & 1 deletion assets/dev/scss/editor/_notice-bar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

&__primary_action {
margin-inline: 12px;
text-transform: uppercase;

a {
background: $white;
Expand Down
20 changes: 16 additions & 4 deletions assets/dev/scss/editor/_templates-modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -502,11 +502,17 @@ label.elementor-template-library-order-label {
}

&:first-child {
border-radius: 3px 3px 0 0;
border-start-start-radius: 3px;
border-start-end-radius: 3px;
border-end-start-radius: 0;
border-end-end-radius: 0;
}

&:last-child {
border-radius: 0 0 3px 3px;
border-start-start-radius: 0;
border-start-end-radius: 0;
border-end-start-radius: 3px;
border-end-end-radius: 3px;
}

.elementor-template-library-template-name {
Expand Down Expand Up @@ -665,12 +671,18 @@ label.elementor-template-library-order-label {
#elementor-template-library-save-template-name {
width: 500px;
padding-inline-start: 25px;
border-radius: getValueByDirection(3px 0 0 3px, 0 3px 3px 0);
border-start-start-radius: 3px;
border-start-end-radius: 0;
border-end-start-radius: 3px;
border-end-end-radius: 0;
}

#elementor-template-library-save-template-submit {
width: 150px;
border-radius: getValueByDirection(0 3px 3px 0, 3px 0 0 3px);
border-start-start-radius: 0;
border-start-end-radius: 3px;
border-end-start-radius: 0;
border-end-end-radius: 3px;
}

#elementor-template-library-import {
Expand Down
Loading
Loading