Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output variable to the postfix definition #202

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Add output variable to the postfix definition #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46b2b04
Replace Package_version var ONE_CLICK_RELEASE_PACKAGE_VERSION in buil…
davseve Aug 7, 2023
cb583d2
package version override condition removal.
davseve Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/bump-channel-version/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,7 @@ runs:
echo "ELEMENTOR_CHANNEL_PACKAGE_VERSION=${ELEMENTOR_CHANNEL_PACKAGE_VERSION}"
echo "NEW_CHANNEL_VERSION=${NEW_CHANNEL_VERSION}"

# This condition is for one click cloud prerelease execution testing manners.
# This condition should be removed once the one click prerelease execution gets to production.
# if [[ "${{ inputs.CHANNEL }}" == "cloud" ]]; then
# echo "PACKAGE_VERSION=${ELEMENTOR_CHANNEL_PACKAGE_VERSION}${{ inputs.POSTFIX }}" >> $GITHUB_ENV
# fi

# ONE_CLICK_RELEASE_PACKAGE_VERSION is used in the one click release workflow to set the release name and file name.
echo ONE_CLICK_RELEASE_PACKAGE_VERSION=${ELEMENTOR_CHANNEL_PACKAGE_VERSION}${{ inputs.POSTFIX }} >> $GITHUB_ENV

if [[ ${{ inputs.CHANNEL }} == "beta" ]]; then
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/one-click-hosting-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ jobs:
- name: Build plugin
uses: ./.github/workflows/build-plugin
with:
#PACKAGE_VERSION: ${{ env.PACKAGE_VERSION }}
PACKAGE_VERSION: ${{ env.ONE_CLICK_RELEASE_PACKAGE_VERSION }}
BUILD_SCRIPT_PATH: "./.github/scripts/build-zip.sh"
- name: Generate changelog
Expand All @@ -74,7 +73,6 @@ jobs:
- name: Create GitHub release
uses: softprops/action-gh-release@v1
with:
#tag_name: ${{ env.PACKAGE_VERSION }}
tag_name: ${{ env.ONE_CLICK_RELEASE_PACKAGE_VERSION }}
target_commitish: ${{ env.CLEAN_REF }}
files: |
Expand Down
Loading