Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise Kv3_4. #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thorstenhater
Copy link

No description provided.

@Helveg
Copy link
Contributor

Helveg commented Sep 23, 2021

  • Benchmark: 12.6s/ms
  • Changes: untested
    • Numerical
    • Functional

@Helveg Helveg added the no-impact No impact on simulation speed label Sep 23, 2021
@thorstenhater
Copy link
Author

Interesting, so it might not be the most impactful mechanism for your benchmark.

Copy link

@noraabiakar noraabiakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think it can make quite a difference.

@Helveg
Copy link
Contributor

Helveg commented Sep 23, 2021

Why did the function names etc change though, didn't they have biological meaning perchance?

@thorstenhater
Copy link
Author

So, before we had a time constant $\tau = c/q$, but this was used only in $1/\tau$ position. So, I changed this
by defining $\rho = 1/\tau$ and folding some constants in. That saves two divisions (at least!) per update.

Can't the compiler do that for me? Yeah, probably, but why not give it a hand; this way we have the guarantee it's
done the way we want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-impact No impact on simulation speed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants