A few mypy/lint fixes #1205
Merged
A few mypy/lint fixes #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we no longer support Python < 3.7 so importlib can be trusted * re-assigning to "dirs" confuses the typechecker * prefer "dir_" rather than redefining a builtin * fix xdg_config_home so that the value cannot be None (at least so that mypy can infer that) * use an array instead of a tuple for a value of varying length No functional change. There are other places where we try to support old Pythons which could now be cleaned up.
Member
|
Nice! Cleaning up always feels good. 🍒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No functional change.
There are other places where we try to support old Pythons which could now be cleaned up.
Checklist
changelog.md.AUTHORSfile (or it's already there).