"Eager" completions for the source command, limiting to *.sql files
#1488
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnemes
approved these changes
Jan 28, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
I think the suggesting only sql files is fine, maybe add config later if anyone really wants it.
Only thing I noticed is when you do source without any text it appears to do a sorted combined list of directories and files; would be nice if files showed up first. But if that is beyond the scope you want here it could be a future pass.
* complete immediately on files in the current directory,even if the text to complete does not start with "." * this resolves a minor bug in which files in the cwd beginning with "." were offered as suggestions before the user had typed "./" * complete only files that end in ".sql" (and directories) * append "/" to suggested directory names * otherwise continue to complete on paths beginning with "./", "~", and "/" in the same way, and continue to offer the punctuation suggestions If the restriction to completion on files that end in ".sql" is too restrictive, we could make it configurable, as noted in a comment. The user can still source a file that does not end in ".sql". It just won't be offered as a completion.
rolandwalker
force-pushed
the
RW/eager-source-completions
branch
from
f78613f to
1ff09cd
Compare
Contributor
Author
Great point. I just tried and it didn't work right. Maybe dotfiles also shouldn't appear. Let's leave those to a future pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...were offered as suggestions before the user had typed./..sql(and directories)./to suggested directory names../,~, and/in the same way, and continue to offer the punctuation suggestions.If the restriction to completion on files that end in
.sqlis too restrictive, we could make it configurable, as noted in a comment.The user can still source a file that does not end in
.sql. It just won't be offered as a completion.Example (first do
touch script.sql):Old (shows history suggestion, but not popup completions):
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.